The code in ecp_384.c is unreachable

ASSIGNED
Assigned to

Status

NSS
Libraries
P2
normal
ASSIGNED
5 years ago
2 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1016 bytes, patch
Wan-Teh Chang
: review?
Robert Relyea
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Bob,

This MXR query shows that the ec_group_set_gfp384 function in
ecp_384.c is not being used:
http://mxr.mozilla.org/security/ident?i=ec_group_set_gfp384

ec_group_set_gfp384 is the sole entry point to ecp_384.c, so
this means the code in ecp_384.c is unreachable.

Should we wire it up and see if the code works?
(Assignee)

Updated

5 years ago
Summary: The code in ecp_394.c is unreachable → The code in ecp_384.c is unreachable
(Assignee)

Comment 1

5 years ago
Created attachment 742195 [details] [diff] [review]
Patch
Assignee: rrelyea → wtc
Status: NEW → ASSIGNED
Attachment #742195 - Flags: review?(rrelyea)
You need to log in before you can comment on or make changes to this bug.