841919 - Turn off --enable-metro on Aurora after Firefox 21 uplift to Aurora

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Metro Firefox is currently enabled on the Nightly channel but is not yet ready for the Aurora audience.  We want to remove --enable-metro from the win32 mozconfigs on mozilla-aurora before Firefox 21 updates are published to the Aurora channel.

Comment 1

[bhavana bajaj [:bajaj]]

Resetting the assignee to lsblakk, looks like I accidentally unassigned it .

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch for mozilla-aurora

Comment 3

[Matt Brubeck (:mbrubeck)]

Moving because we don't seem to have the right approval flags in the Metro product.  (I'll file a separate bug about that.)

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 715526 [details] [diff] [review]
patch for mozilla-aurora

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 813488

User impact if declined: unstable Metro code ships to Aurora users

Testing completed (on m-c, etc.): reverts a config change that just recently landed on m-c

Risk to taking this patch (and alternatives if risky): Very low risk. We are already building without --enable-metro on all platforms besides Win32.

String or UUID changes made by this patch: None.

Comment 5

[Mike Hommey [:glandium]]

Would it make sense to revert changeset 784b9beebe90 from bug 755725 on aurora, so that we have some more time to deal with the fallout?

Comment 6

[Jim Mathies [:jimm]]

(In reply to Mike Hommey [:glandium] from comment #5)
> Would it make sense to revert changeset 784b9beebe90 from bug 755725 on
> aurora, so that we have some more time to deal with the fallout?

(bug 755724)

https://hg.mozilla.org/mozilla-central/rev/784b9beebe90

Wouldn't this create a package-manifest.in merge nightmare for aurora?

More generally, has the fall out been that bad? Seems like most issues that have come up have been minor.

Comment 7

[Mike Hommey [:glandium]]

(In reply to Jim Mathies [:jimm] from comment #6)
> (In reply to Mike Hommey [:glandium] from comment #5)
> > Would it make sense to revert changeset 784b9beebe90 from bug 755725 on
> > aurora, so that we have some more time to deal with the fallout?
> 
> (bug 755724)
> 
> https://hg.mozilla.org/mozilla-central/rev/784b9beebe90
> 
> Wouldn't this create a package-manifest.in merge nightmare for aurora?

I guess you mean backport nightmare. Good question. Do we backport many changes that require package-manifest.in updates?

> More generally, has the fall out been that bad? Seems like most issues that
> have come up have been minor.

I'm more concerned about the fallout that hasn't been caught yet, but then, we also still have 12 weeks of aurora+beta to find and fix them.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 715526 [details] [diff] [review]
patch for mozilla-aurora

I just completed the merge day steps and had already removed these lines, so patch not needed (thanks for providing it though!)

http://hg.mozilla.org/releases/mozilla-aurora/rev/631304d1cf47

Comment 9

[u279076]

I've added this to my list of bugs to verify before sign-off tomorrow.

Comment 10

[u279076]

> Firefox 21.0a1 2013-01-31
I wasn't able to launch metro from command line but I was able to launch it in metro mode from the start screen.

> Firefox 21.0a2 2013-02-22
I wasn't able to launch metro from command line nor was I able to launch it in metro mode from the start screen.

Unfortunately I was unable to confirm the command line option because I couldn't seem to get it to work on known working builds. However I at least confirmed Firefox Aurora 21 is incapable of being launched in Metro mode from the start screen. As such I'm marking this verified fixed. Please reopen if you find you are able to launch Aurora 21 in Metro mode.