Closed
Bug 841938
Opened 11 years ago
Closed 11 years ago
Implement nsAndroidHistory::SetURITitle
Categories
(Firefox for Android Graveyard :: Data Providers, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: Margaret, Assigned: Margaret)
Details
Attachments
(1 file)
|
9.38 KB,
patch
|
wesj
:
review+
kats
:
feedback+
|
Details | Diff | Splinter Review |
Right now we're updating a history entry's title whenever Tab's updateTitle method is called, but we can just let Gecko take care of this for us by implementing nsAndroidHistory::SetURITitle. This is nice because then Tab doesn't need to worry about updating history, and this avoids us calling GlobalHistory.update() more often than necessary.
Attachment #714633 -
Flags: review?(wjohnston)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 714633 [details] [diff] [review] patch LGTM. We'll have to watch out for any regressions. Good to be closer in line with desktop though! If kats has time, a quick peek to make sure everything is ok on the bridge side of stuff would be nice.
Attachment #714633 -
Flags: review?(wjohnston)
Attachment #714633 -
Flags: review+
Attachment #714633 -
Flags: feedback?(bugmail.mozilla)
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → margaret.leibovic
|
||
Comment 2•11 years ago
|
||
Comment on attachment 714633 [details] [diff] [review] patch Review of attachment 714633 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #714633 -
Flags: feedback?(bugmail.mozilla) → feedback+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/33feebc4a09f
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/33feebc4a09f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•