Intermittent dom/media/tests/crashtests/837421.html | Exited with code 1 during test run | application crashed [@ std::_Tree<std::_Tmap_traits<int,CSF::StreamInfo...] [@ sipcc::PeerConnectionMedia::GetTransportFlow(int, bool)]

RESOLVED FIXED

Status

()

Core
WebRTC: Networking
P1
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

({crash, intermittent-failure})

Trunk
crash, intermittent-failure
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC], [blocking-webrtc-], [qa-], crash signature)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=19791013&tree=Mozilla-Inbound

Probably a missing mMedia check against null

Operating system: Mac OS X
                  10.6.8 10K549
CPU: amd64
     family 6 model 23 stepping 10
     2 CPUs

Crash reason:  EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
Crash address: 0xd8

Thread 0 (crashed)
 0  XUL!sipcc::PeerConnectionMedia::GetTransportFlow(int, bool) [stl_tree.h : 476 + 0x0]
    rbx = 0x00000000000000d0   r12 = 0x0000000000000010
    r13 = 0x0000000117021cd0   r14 = 0x00007fff5fbfb770
    r15 = 0x000000000000ffff   rip = 0x000000010271f810
    rsp = 0x00007fff5fbfb730   rbp = 0x00007fff5fbfb750
    Found by: given as instruction pointer in context
 1  XUL!sipcc::PeerConnectionImpl::ConnectDataConnection(unsigned short, unsigned short, unsigned short) [PeerConnectionImpl.cpp:f1f4c2e87acf : 643 + 0xb]
    rip = 0x0000000102730927   rsp = 0x00007fff5fbfb760
    rbp = 0x00007fff5fbfb7a0
    Found by: stack scanning
 2  XUL!NS_InvokeByIndex_P [xptcinvoke_x86_64_unix.cpp:f1f4c2e87acf : 162 + 0x3]
    rip = 0x000000010224d9ad   rsp = 0x00007fff5fbfb7b0
    rbp = 0x00007fff5fbfb840
    Found by: stack scanning
 3  libnspr4.dylib!PR_GetCurrentThread [ptthread.c : 583 + 0xb]
    rip = 0x000000010041cb05   rsp = 0x00007fff5fbfb7d0
    rbp = 0x00007fff5fbfb840
    Found by: stack scanning
 4  XUL!nsThreadManager::GetIsMainThread(bool*) [nsThreadManager.cpp:f1f4c2e87acf : 272 + 0x4]
    rip = 0x000000010223a7c2   rsp = 0x00007fff5fbfb7f0
    rbp = 0x00007fff5fbfb840
    Found by: stack scanning
 5  XUL!XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) [XPCWrappedNative.cpp:f1f4c2e87acf : 3085 + 0x4]
    rip = 0x0000000101ba00e0   rsp = 0x00007fff5fbfb850
    rbp = 0x00007fff5fbfbcc0
    Found by: stack scanning
 6  XUL!nsBindingManager::GetXBLChildNodesFor(nsIContent*) [nsBindingManager.cpp:f1f4c2e87acf : 779 + 0x4]
    rip = 0x000000010176677e   rsp = 0x00007fff5fbfb870
(Assignee)

Comment 1

5 years ago
Created attachment 714708 [details] [diff] [review]
check mMedia before connecting a data connection

Updated

5 years ago
Blocks: 826044
(Assignee)

Updated

5 years ago
Attachment #714708 - Flags: review?(ekr)
Whiteboard: [WebRTC], [blocking-webrtc+]
(Assignee)

Updated

5 years ago
Summary: Intermittent PROCESS-CRASH | dom/media/tests/crashtests/837421.html | application crashed [@ sipcc::PeerConnectionMedia::GetTransportFlow(int, bool)] → Intermittent PROCESS-CRASH | dom/media/tests/crashtests/837421.html | application crashed [@ sipcc::PeerConnectionMedia::GetTransportFlow(int, bool)] or TEST-UNEXPECTED_FAIL | dom/media/tests/crashtests/837421.html | Exited with code 1 during test run
(Assignee)

Comment 2

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=19842959&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=19842555&tree=Mozilla-Inbound

REFTEST TEST-START | file:///C:/talos-slave/test/build/reftest/tests/dom/media/tests/crashtests/837421.html | 536 / 2259 (23%)
REFTEST TEST-PASS | file:///C:/talos-slave/test/build/reftest/tests/dom/media/tests/crashtests/837421.html | (LOAD ONLY)
REFTEST INFO | Loading a blank page
TEST-UNEXPECTED-FAIL | file:///C:/talos-slave/test/build/reftest/tests/dom/media/tests/crashtests/837421.html | Exited with code -1073741819 during test run
INFO | automation.py | Application ran for: 0:02:32.432000
INFO | automation.py | Reading PID log: c:\users\cltbld\appdata\local\temp\tmp4a8miwpidlog
PROCESS-CRASH | file:///C:/talos-slave/test/build/reftest/tests/dom/media/tests/crashtests/837421.html | application crashed [@ std::_Tree<std::_Tmap_traits<int,mozilla::RefPtr<mozilla::TransportFlow>,std::less<int>,std::allocator<std::pair<int const ,mozilla::RefPtr<mozilla::TransportFlow> > >,0> >::_Lbound(int const &)]
Crash dump filename: c:\users\cltbld\appdata\local\temp\tmpax1eaw\minidumps\00cbf31a-cf28-4196-a8c6-86a0617495ec.dmp
Operating system: Windows NT
                  6.1.7600 
CPU: x86
     GenuineIntel family 6 model 23 stepping 10
     2 CPUs

Crash reason:  EXCEPTION_ACCESS_VIOLATION_READ
Crash address: 0x6c

Thread 0 (crashed)
 0  xul.dll!std::_Tree<std::_Tmap_traits<int,mozilla::RefPtr<mozilla::TransportFlow>,std::less<int>,std::allocator<std::pair<int const ,mozilla::RefPtr<mozilla::TransportFlow> > >,0> >::_Lbound(int const &) [xtree : 1742 + 0x0]
    eip = 0x6cc40a18   esp = 0x0030e3fc   ebp = 0x0030e3fc   ebx = 0x07fca420
    esi = 0x00000068   edi = 0x0030e43c   eax = 0x0030e438   ecx = 0x00000068
    edx = 0x00000000   efl = 0x00210246
    Found by: given as instruction pointer in context
 1  xul.dll!std::_Tree<std::_Tmap_traits<int,webrtc::MapItem *,std::less<int>,std::allocator<std::pair<int const ,webrtc::MapItem *> >,0> >::find(int const &) [xtree : 1424 + 0xa]
    eip = 0x6cc4ff1f   esp = 0x0030e404   ebp = 0x0030e414
    Found by: call frame info
 2  xul.dll!sipcc::PeerConnectionMedia::GetTransportFlow(int,bool) [PeerConnectionMedia.h:ea6e27e21be8 : 294 + 0xf]
    eip = 0x6cc4374d   esp = 0x0030e41c   ebp = 0x0030e42c
    Found by: call frame info
 3  xul.dll!sipcc::PeerConnectionImpl::ConnectDataConnection(unsigned short,unsigned short,unsigned short) [PeerConnectionImpl.cpp:ea6e27e21be8 : 630 + 0x13]
    eip = 0x6cc4dd24   esp = 0x0030e434   ebp = 0x0030e44c
    Found by: call frame info
Crash Signature: [@ sipcc::PeerConnectionMedia::GetTransportFlow(int, bool)] [@ std::_Tree<std::_Tmap_traits<int,mozilla::RefPtr<mozilla::TransportFlow>,std::less<int>,std::allocator<std::pair<int const ,mozilla::RefPtr<mozilla::TransportFlow> > > 0> >::_Lbound(in&hellip;
Keywords: crash, intermittent-failure
Summary: Intermittent PROCESS-CRASH | dom/media/tests/crashtests/837421.html | application crashed [@ sipcc::PeerConnectionMedia::GetTransportFlow(int, bool)] or TEST-UNEXPECTED_FAIL | dom/media/tests/crashtests/837421.html | Exited with code 1 during test run → Intermittent dom/media/tests/crashtests/837421.html | Exited with code 1 during test run | application crashed [@ sipcc::PeerConnectionMedia::GetTransportFlow(int, bool)]
Comment hidden (Treeherder Robot)
https://tbpl.mozilla.org/php/getParsedLog.php?id=19839390&tree=Fx-Team
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 23

5 years ago
FYI, I've made several thousand runs of this locally (linux) with no crashes. I also tried loading the machine with builds.

There are crashes logged here for all Desktop platforms, though mac has more (considerably).
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86_64 → All
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Randell, any news on this? :-)
Flags: needinfo?(rjesup)
(Assignee)

Comment 60

5 years ago
ekr considers this a wallpaper fix for a worse problem, which perhaps will be dealt with in bug 844493.  This is unsure as we don't actually know how mMedia can be null here.
Flags: needinfo?(rjesup)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Updated

5 years ago
Summary: Intermittent dom/media/tests/crashtests/837421.html | Exited with code 1 during test run | application crashed [@ sipcc::PeerConnectionMedia::GetTransportFlow(int, bool)] → Intermittent dom/media/tests/crashtests/837421.html | Exited with code 1 during test run | application crashed [@ std::_Tree<std::_Tmap_traits<int,CSF::StreamInfo...] [@ sipcc::PeerConnectionMedia::GetTransportFlow(int, bool)]
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(In reply to Ed Morley [:edmorley UTC+0] from comment #59)
> Randell, any news on this? :-)

(In reply to Randell Jesup [:jesup] from comment #60)
> ekr considers this a wallpaper fix for a worse problem, which perhaps will
> be dealt with in bug 844493.  This is unsure as we don't actually know how
> mMedia can be null here.

Any more news since the above?
WebRTC failures (this bug and others) are dominating the top orange list :-(
Flags: needinfo?(rjesup)
(Assignee)

Comment 267

5 years ago
We expect the DISPATCH_SYNC fix to land in the next day or so (we've been through a few rounds of review, and are waiting on a hopefully final review from derf).  (I think it's actually on a different bug than I cite above; several were filed that devolve to the same issue).

On the other issues, it's a similar picture (the underrun assertions are also awaiting review after several passes).  

The nsThread leak we're hot on the tail of this moment (now that we've fingered it as being webrtc, which I suspected but had no proof of until mccr8 helped).
Flags: needinfo?(rjesup)
Comment hidden (Treeherder Robot)
(In reply to Randell Jesup [:jesup] from comment #267)
> We expect the DISPATCH_SYNC fix to land in the next day or so (we've been
> through a few rounds of review, and are waiting on a hopefully final review
> from derf).  (I think it's actually on a different bug than I cite above;
> several were filed that devolve to the same issue).
> 
> On the other issues, it's a similar picture (the underrun assertions are
> also awaiting review after several passes).  
> 
> The nsThread leak we're hot on the tail of this moment (now that we've
> fingered it as being webrtc, which I suspected but had no proof of until
> mccr8 helped).

Thank sounds great - thank you :-)
bah,
s/Thank/That/
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 318

5 years ago
(In reply to Randell Jesup [:jesup] from comment #60)
> ekr considers this a wallpaper fix for a worse problem, which perhaps will
> be dealt with in bug 844493.  This is unsure as we don't actually know how
> mMedia can be null here.

Ok, we now have a clear instance of this bug after landing bug 844493, so we need to investigate it independently.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 331

5 years ago
Created attachment 729950 [details] [diff] [review]
Disable ConnectDataConnection if we aren't in a call; add logs
(Assignee)

Comment 332

5 years ago
Comment on attachment 729950 [details] [diff] [review]
Disable ConnectDataConnection if we aren't in a call; add logs

This will become moot soon when we land the DataChannel negotiation code, but I see no reason not to block incorrect API uses.
Attachment #729950 - Flags: review?(ekr)
(Assignee)

Updated

5 years ago
Attachment #714708 - Attachment is obsolete: true
Attachment #714708 - Flags: review?(ekr)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Updated

5 years ago
Whiteboard: [WebRTC], [blocking-webrtc+] → [WebRTC], [blocking-webrtc-]
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment on attachment 729950 [details] [diff] [review]
Disable ConnectDataConnection if we aren't in a call; add logs

Review of attachment 729950 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp
@@ +627,5 @@
>      // and we increase the number of streams dynamically as needed.
>      return NS_OK;
>    }
> +
> +  if (!mMedia) {

This is a can't happen, right? Can we please MOZ_CRASH()?

Certainly, we shouldn't be proceeding,right?
Attachment #729950 - Flags: review?(ekr) → review-
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)