"ASSERTION: CSS strings must be quoted"

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jruderman, Assigned: zwol)

Tracking

(Blocks 1 bug, {assertion, regression, testcase})

Trunk
mozilla21
x86_64
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Posted image testcase
###!!! ASSERTION: CSS strings must be quoted with ' or ": 'quoteChar == '\'' || quoteChar == '"'', file layout/style/nsStyleUtil.cpp, line 63


Regression from bug 543151?
Posted file stack
Posted patch patchSplinter Review
Well, this is embarrassing.  When I redid the url(...) parser, I forgot to initialize aToken.mSymbol in the unquoted case, so we were getting junk from previous tokens.  layout/style mochitests would have caught the problem, but they ignore assertions.

Patch fixes the missing initialization and adds a crashtest based on your test case (I switched it from SVG to HTML).
Assignee: nobody → zackw
Status: NEW → ASSIGNED
Attachment #715000 - Flags: review?(cam)
Attachment #715000 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/eb1a14e09f50
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.