Closed Bug 842134 Opened 10 years ago Closed 10 years ago

"ASSERTION: CSS strings must be quoted"

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: jruderman, Assigned: zwol)

References

Details

(Keywords: assertion, regression, testcase)

Attachments

(3 files)

testcase
76 bytes, image/svg+xml
Details
stack
12.58 KB, text/plain
Details
patch
1.60 KB, patch
heycam
: review+
Details | Diff | Splinter Review
Attached image testcase — 
###!!! ASSERTION: CSS strings must be quoted with ' or ": 'quoteChar == '\'' || quoteChar == '"'', file layout/style/nsStyleUtil.cpp, line 63


Regression from bug 543151?
Attached file stack — 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
Well, this is embarrassing.  When I redid the url(...) parser, I forgot to initialize aToken.mSymbol in the unquoted case, so we were getting junk from previous tokens.  layout/style mochitests would have caught the problem, but they ignore assertions.

Patch fixes the missing initialization and adds a crashtest based on your test case (I switched it from SVG to HTML).
Assignee: nobody → zackw
Status: NEW → ASSIGNED

        Attachment #715000 -
        Flags: review?(cam)

        Attachment #715000 -
        Flags: review?(cam) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/eb1a14e09f50
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21

          You need to log in
          before you can comment on or make changes to this bug.