Closed Bug 842134 Opened 9 years ago Closed 9 years ago
"ASSERTION: CSS strings must be quoted"
###!!! ASSERTION: CSS strings must be quoted with ' or ": 'quoteChar == '\'' || quoteChar == '"'', file layout/style/nsStyleUtil.cpp, line 63 Regression from bug 543151?
Well, this is embarrassing. When I redid the url(...) parser, I forgot to initialize aToken.mSymbol in the unquoted case, so we were getting junk from previous tokens. layout/style mochitests would have caught the problem, but they ignore assertions. Patch fixes the missing initialization and adds a crashtest based on your test case (I switched it from SVG to HTML).
Assignee: nobody → zackw
Status: NEW → ASSIGNED
Attachment #715000 - Flags: review?(cam)
Attachment #715000 - Flags: review?(cam) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb1a14e09f50 Thanks for the quick review.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.