842151 - 'null' message breaks the threadUI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: patch

I don't know how this happened, but I received a empty message. This message has been stored has |null| in the database. Now I cannot see any message from that thread becuase the escapeHTML method throws an uncatched exception.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 714932 [details] [diff] [review]
patch

That seems like a workaround but let's not break user phone for this version. 

Can you add the bug number as a comment before landing so this won't be regressed.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

Triage: since there is no STR to understand how easy this is reproducible. blocking-b2g minus to not block release, but to land given vivien's approval

Comment 3

[Andrea Marchesini [:baku]]

> That seems like a workaround but let's not break user phone for this
> version. 

I agree with you: this is a workaround for some other problem, but this just happened to me and looks hard to find a way to reproduce this issue.

> Can you add the bug number as a comment before landing so this won't be
> regressed.

I cannot land this patch. If you want I can send a pull request...

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 714932 [details] [diff] [review]
patch

Clearing the b2g18 approval nom since this is already gaia approved.

Comment 5

[Andrea Marchesini [:baku]]

Do you need a pull request for landing this patch?

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Andrea Marchesini (:baku) from comment #5)
> Do you need a pull request for landing this patch?

I have secret hopes that settings approval-gaia+ will make this patch finds its way to the right branch if it has already landed on master.

That will save me some time if you can do a PR with the patch so I can merge it on master and add the changeset here for letting the magic happens.

Comment 7

[Andrea Marchesini [:baku]]

https://github.com/mozilla-b2g/gaia/pull/8298

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

master@aca113a
v1-train@90a617a