84216 - Mac scripts need an option to pull by date

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Simon Fraser [no longer active]]

We need a build option on Mac to pull by date. The tinderboxes would use this.

Comment 1

[Chris McAfee]

Or, without such an option, it is possible for changes to hit the build up to 15
minutes after the initial tinderbox mail goes out.  This is confusing for
devlopers who are used to pull-by-date behavior on other platforms.

Comment 2

[Simon Fraser [no longer active]]

Attachment: Patch to add support for pulling by date

Comment 3

[Simon Fraser [no longer active]]

This patch adds support for pulling by date. If 'options pull_by_date 1' is in 
your build prefs file, it will pull using the current local time. Any modules 
that are already pulled by date (as specified in the MozillaCheckoutList.txt 
file) will continue to be pulled on that date.

Comment 4

[Jon Granrose]

be good to get this before, but setting for 0.9.3 since it's not a 0.9.2 stopper.

Comment 5

[Simon Fraser [no longer active]]

Pulling back. Looking for r= (peterv), and sr= (scc).

Comment 6

[Peter Van der Beken [:peterv]]

r=peterv.

Comment 7

[Scott Collins]

sr=scc

Comment 8

[rubydoo123]

moving to 1.0

Comment 9

[Conrad Carlen (not reading bugmail)]

Why is that? Looks ready to check in to me. This could stop a lot of mid-checkin
bustage on Mac TinderBoxes.

Comment 10

[J.J. Enser]

Just to confirm, will that option also work when pulling from a branch ?
Last I saw (and tested with MacCVS 2.6d5) was that any date argument was ignored 
when using a branch tag AND a date stamp.

Comment 11

[Simon Fraser [no longer active]]

It got moved because I don't have time to babysit this into the tree before I go 
on vacation; feel free to take it and check it in if you like. We should test 
that MacCVS Pro does the correct thing tho.

Comment 12

[Chris McAfee]

you can't pull-by-date on any branch, on any platform as far
as I understand it.  cvs takes one tag argument, I believe
branch tag wins over date tag as jj describes.

Comment 13

[Conrad Carlen (not reading bugmail)]

If the branch tag wins, we will have the same behavior on branches that we've
always had. I don't think that's a problem because the point of this patch, I
thought, is to protect against mid-checkin bustage from large, tree-spanning
checkins. How often do those happen on a branch?

Comment 14

[J.J. Enser]

Conrad: good point. I think you're right. 
Chris: Can't you use -r branchname -D "2001-06-20 07:30" ?
I'm no expect in Unix CVS, but even if the syntax above doesn't work, MacCVS Pro 
can theoretically be scripted that way:
  check out module "foo.txt" revision "branchname" date "06/20/2001 07:30:00"

I have one more question about the patch. It seems like if we have several 
modules to pull - and we do - each module will be pulled with a different date 
stamp, which could potentially be far apart from one another. If waht we want is 
to avoid mid-checkin bustage, shouldn't we use a _single_ date stamp for all 
pulls ?

Comment 15

[Simon Fraser [no longer active]]

> It seems like if we have several 
> modules to pull - and we do - each module will be pulled with a different date 

No; the script gets the date once, then passes that into the routine that
runs through the checkoutlist.txt file, and checks out each module in the file.
So the same date is used for all modules (that don't specify a date in the
checkoutlist.txt file).

Comment 16

[J.J. Enser]

Doh. that's why I don't write too much perl :-/

So once this lands on the trunk I suppose all I need is to add "options   
pull_by_date   1" on the various Mac Tinderboxen local prefs, right?

actually, I can already do so so that this will become effective immediately 
after your checkin.

Comment 17

[Simon Fraser [no longer active]]

Checked in.

Comment 18

[Jon Granrose]

over to jj for verification.

Comment 19

[J.J. Enser]

verified