842194 - Download manager does not update when removing download

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Open Download Manager
2. Select an inactive download
3. Edit - Remove From List
Expected result: download manager updates immediately
Actual result: need to close and reopen download manager

The problem is that the removed download observer needs to be updated for the id/guid change.

Comment 1

[[e-mail]]

Attachment: Proposed patch [Checkin: Comments 6 and 9]

Fortunately I had already updated treeView.js to remove a download by guid, but I hadn't realised that the notification had changed. Oops.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

I get the below on trunk (2.19) an Aurora (2.18) when clicking a trash can icon in the Download Manager window at least twice. I presume that will be fixed through this bug?

Error: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDownload.remove]
Source File: chrome://communicator/content/downloads/treeView.js
Line: 222

Comment 3

[[e-mail]]

(In reply to Jens Hatlak from comment #2)
> I get the below on trunk (2.19) an Aurora (2.18) when clicking a trash can
> icon in the Download Manager window at least twice. I presume that will be
> fixed through this bug?
> 
> Error: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111
> (NS_ERROR_NOT_AVAILABLE) [nsIDownload.remove]
> Source File: chrome://communicator/content/downloads/treeView.js
> Line: 222

Indeed, feel free to try the patch out for yourself!

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 714989 [details] [diff] [review]
Proposed patch [Checkin: Comments 6 and 9]

As expected, with the patch, clicking a trash can successfully removes a download again, so clicking it again is impossible and the error messages cannot be triggered anymore. :-)

Comment 5

[Philip Chee]

Comment on attachment 714989 [details] [diff] [review]
Proposed patch [Checkin: Comments 6 and 9]

r=me

Comment 6

[[e-mail]]

Pushed comm-central changeset ba229520fc5f.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 714989 [details] [diff] [review]
Proposed patch [Checkin: Comments 6 and 9]

[Approval Request Comment]
Regression caused by (bug #): Bug 833015
User impact if declined: Items stay in DLMGR, UI seems to be broken
Testing completed (on m-c, etc.): Landed on c-c and has f+
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None

Comment 8

[Philip Chee]

Comment on attachment 714989 [details] [diff] [review]
Proposed patch [Checkin: Comments 6 and 9]

a=me

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 714989 [details] [diff] [review]
Proposed patch [Checkin: Comments 6 and 9]

http://hg.mozilla.org/releases/comm-aurora/rev/73b92eaf5da5