Closed Bug 842198 Opened 7 years ago Closed 7 years ago
_bug822367 .js test to browser/
The rather new browser_bug822367.js test tests that the new doorhanger UI for mixed content notifications is working. Currently the test is placed in content/base/test/chrome/, I think that's the wrong location for the test. content/ is core code that's the same in all apps that use Gecko. I propose that this test gets moved to browser/ somewhere (also because SeaMonkey testboxen execute the mochitest browser chrome tests and currently SM does not implement the mixed content doorhanger UI).
Also the UI itself is implemented in browser/, so that's another reason to move it there :)
This patch moves the tests to browser/base/content/test. I tested locally that all tests still pass.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #715765 - Flags: review?(tanvi)
Comment on attachment 715765 [details] [diff] [review] Patch Thanks Frank for your work on this! Can you do a push to try on one platform before landing this?
Attachment #715765 - Flags: review?(tanvi) → review+
Tested on try and pushed to m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/111c835cedf6 Leaving open as this patch should also land on -aurora.
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: [leave open]
Target Milestone: --- → Firefox 22
Link for try run: https://tbpl.mozilla.org/?rev=92b1b08b1199&tree=Try
Comment on attachment 715765 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Thousands of test failures on SeaMonkey aurora builds :) (when this test fails it causes problems for subsequent tests) Testing completed (on m-c, etc.): Tests works fine on mozilla-central Risk to taking this patch (and alternatives if risky): Only moves a few test files to another location, no code changes String or UUID changes made by this patch: none
Attachment #715765 - Flags: approval-mozilla-aurora?
Attachment #715765 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/c93589667c49
You need to log in before you can comment on or make changes to this bug.