Closed Bug 842249 Opened 11 years ago Closed 11 years ago

FTU is not checking properly if Facebook is enabled or not

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: jmcf, Assigned: jmcf)

References

Details

Attachments

(1 file)

Pointer to GH PR
189 bytes, text/html
fcampo
: review+
lsblakk
: approval-gaia-v1+
Details 
The following error appears in the console

[JavaScript Error: "ReferenceError: utilities is not defined" {file: "app://communications.gaiamobile.org/ftu/js/facebook.js" line: 132}]
Attached file Pointer to GH PR — 
simple change, only a name mispelling while calling a component
Attachment #715073 - Flags: review?(fernando.campo)
Attachment #715073 - Flags: review?(fernando.campo) → review+
https://github.com/mozilla-b2g/gaia/commit/4e02825797123a2e3c93bb5c1eb7a38c7c947e8a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 715073 [details]
Pointer to GH PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): changes in component names
User impact if declined: high if Fb is not really enabled on their phone, they can have a malfunctioning FTU 
Testing completed: yes
Risk to taking this patch (and alternatives if risky): very low
Attachment #715073 - Flags: approval-gaia-v1?
Comment on attachment 715073 [details]
Pointer to GH PR

Approving typo correction fix for v1-train uplift.
Attachment #715073 - Flags: approval-gaia-v1? → approval-gaia-v1+
v1-train@9929b8bb8a8a323a0a845873b0318894f90b656b
status-b2g18: affected → fixed
Jose, if I'm not mistaken, this should go to tef+, right ? Otherwise facebook import doesn't work ?
Flags: needinfo?(jmcf)
blocking-b2g: --- → tef?
yes, this should go to v1.0.1 as well
Flags: needinfo?(jmcf)
Blocks: 837111
blocking-b2g: tef? → tef+
status-b2g18-v1.0.1: wontfix → affected
v1.0.1: aae64f81bba4ee7c6f146ebb385b04402ce9a6d2
status-b2g18-v1.0.1: affected → fixed
Verified fixed the following: 
Ability to enable Facebook and import Facebook contacts during FTU. After FTU was finished the Contacts app showed the Facebook contacts as well.

Verified fixed on Unagi with the following:
Build ID: 20130325070201
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia: 701b594c3e320030c538aa19f702764b29a6cc1c
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: