Thunderbird/SeaMonkey comm-central builds fail with "KeyError: 'MOZ_APP_VENDOR'"

RESOLVED FIXED in Thunderbird 21.0

Status

MailNews Core
Build Config
--
blocker
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: mcsmurf, Assigned: standard8)

Tracking

Trunk
Thunderbird 21.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Comment 1

4 years ago
Whoops, hit enter too soon.

Currently Thunderbird/SeaMonkey builds fail with this error:

/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/mozilla/config/nsinstall -D ../../mozilla/dist/
/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/_virtualenv/bin/python /builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/toolkit/mozapps/installer/informulate.py \
		../../mozilla/dist//thunderbird-21.0a1.en-US.linux-x86_64.json \
		BUILDID=20130217235329 \
		MOZ_SOURCE_REPO=http://hg.mozilla.org/mozilla-central \
		MOZ_SOURCE_STAMP=de56ae61946d \
		MOZ_PKG_PLATFORM=linux-x86_64
Traceback (most recent call last):
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/toolkit/mozapps/installer/informulate.py", line 46, in <module>
    main()
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/toolkit/mozapps/installer/informulate.py", line 37, in main
    all_key_value_pairs = dict([(x.lower(), buildconfig.substs[x]) for x in important_substitutions])
KeyError: 'MOZ_APP_VENDOR'
make[3]: Leaving directory `/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/mail/installer'

Possible solution can be found in Bug 839298 Comment 17. But I think the
real/correct(?) solution would be to make sure all the vars listed in
http://hg.mozilla.org/mozilla-central/file/524e7bc67431/toolkit/mozapps/installer/informulate.py are included (probably not the right term) in the buildconfig python module. Not sure how exactly this works though...
Blocks: 839298
Severity: normal → blocker
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Comment 2

4 years ago
Created attachment 715110 [details] [diff] [review]
The fix

Ok, this fixes it enough to get us running again
Attachment #715110 - Flags: review?(bugzilla)

Updated

4 years ago
Attachment #715110 - Flags: review?(bugzilla) → review+
Attachment #715110 - Attachment is patch: true
(Assignee)

Comment 3

4 years ago
I've a feeling the information may still be wrong for us in the json file, but at least this will get us green again.
Assignee: nobody → mbanner
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0

Comment 4

3 years ago
Pushed to comm-central
comm-central changeset e4a72afda8ab

http://hg.mozilla.org/comm-central/rev/e4a72afda8ab
You need to log in before you can comment on or make changes to this bug.