Last Comment Bug 842254 - Thunderbird/SeaMonkey comm-central builds fail with "KeyError: 'MOZ_APP_VENDOR'"
: Thunderbird/SeaMonkey comm-central builds fail with "KeyError: 'MOZ_APP_VENDOR'"
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- blocker (vote)
: Thunderbird 21.0
Assigned To: Mark Banner (:standard8)
:
:
Mentors:
Depends on:
Blocks: 839298
  Show dependency treegraph
 
Reported: 2013-02-18 02:03 PST by Frank Wein [:mcsmurf]
Modified: 2014-10-05 07:03 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
The fix (929 bytes, patch)
2013-02-18 03:53 PST, Mark Banner (:standard8)
bugspam.Callek: review+
Details | Diff | Splinter Review

Description Frank Wein [:mcsmurf] 2013-02-18 02:03:10 PST

    
Comment 1 Frank Wein [:mcsmurf] 2013-02-18 02:05:13 PST
Whoops, hit enter too soon.

Currently Thunderbird/SeaMonkey builds fail with this error:

/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/mozilla/config/nsinstall -D ../../mozilla/dist/
/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/_virtualenv/bin/python /builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/toolkit/mozapps/installer/informulate.py \
		../../mozilla/dist//thunderbird-21.0a1.en-US.linux-x86_64.json \
		BUILDID=20130217235329 \
		MOZ_SOURCE_REPO=http://hg.mozilla.org/mozilla-central \
		MOZ_SOURCE_STAMP=de56ae61946d \
		MOZ_PKG_PLATFORM=linux-x86_64
Traceback (most recent call last):
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/toolkit/mozapps/installer/informulate.py", line 46, in <module>
    main()
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/toolkit/mozapps/installer/informulate.py", line 37, in main
    all_key_value_pairs = dict([(x.lower(), buildconfig.substs[x]) for x in important_substitutions])
KeyError: 'MOZ_APP_VENDOR'
make[3]: Leaving directory `/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/mail/installer'

Possible solution can be found in Bug 839298 Comment 17. But I think the
real/correct(?) solution would be to make sure all the vars listed in
http://hg.mozilla.org/mozilla-central/file/524e7bc67431/toolkit/mozapps/installer/informulate.py are included (probably not the right term) in the buildconfig python module. Not sure how exactly this works though...
Comment 2 Mark Banner (:standard8) 2013-02-18 03:53:59 PST
Created attachment 715110 [details] [diff] [review]
The fix

Ok, this fixes it enough to get us running again
Comment 3 Mark Banner (:standard8) 2013-02-18 04:07:35 PST
I've a feeling the information may still be wrong for us in the json file, but at least this will get us green again.

Note You need to log in before you can comment on or make changes to this bug.