Closed Bug 842306 Opened 11 years ago Closed 11 years ago

Comments in events

Categories

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

task
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: pierros, Assigned: nemo-yiannis)

Details

(Whiteboard: u=user c=events p=2)

We need to implement commenting system in events (same way that we do in reports)

Visually they should be identical to commenting in reports.

Can add comment: Reps and Vouched-mozillians
Can delete comments: creator own, admin all

Emailing notifications: Event owner on new comments (with preference in settings)

Visibility: Only to all authorized users, unauthed cannot see (or comment)
Whiteboard: u=user c=events p=2
Assignee: nobody → johngiannelos
Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/014d71ece6313fdc61d45db9ed6bafefe12d3030
[Fix bug 842306] Initial implementation of comments in events

* Add EventComment model and EventCommentForm
* Implement comment in events/views.py
* Add delete event comment to URLs
* Add delete comment permissions
* Fixes in CSS
* Send email to event owner on comment
* Add settings for email on comment
* Add tests

https://github.com/mozilla/remo/commit/5f2433dd85ba0af48cb1c7efc0c3ead27a8bfcaa
Merge pull request #363 from johngian/842306

[Fix bug 842306] Initial implementation of comments in events
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Hi all , 
I checked and have the following status on each 

> Visually they should be identical to commenting in reports.
is 
 
> Can add comment: Reps and Vouched-mozillians 
implemented (me -Rep, Andreea Pod account vouched )

> Can delete comments: creator own, 
implemeted 

> admin all
if I have rights is not implemented, if I don't have rights - not tested

> Emailing notifications: Event owner on new comments (with preference in
> settings)
not working 
https://reps-dev.allizom.org/e/test-by-ioana/

> Visibility: Only to all authorized users, unauthed cannot see (or comment)
implemented. ok
(In reply to Ioana Chiorean from comment #2)
> Hi all , 
> I checked and have the following status on each 
Reopening bug due to missing specifications:

> > Can delete comments: admin all
> if I have rights is not implemented, if I don't have rights - not tested
> 
> > Emailing notifications: Event owner on new comments (with preference in
> > settings)
> not working 
> https://reps-dev.allizom.org/e/test-by-ioana/
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Tested with correct event https://reps.allizom.org/e/correct-test-by-ioana/
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
All stories specified in the descriptios are implemented and verified.
Status: RESOLVED → VERIFIED
Product: Mozilla Reps → Mozilla Reps Graveyard
You need to log in before you can comment on or make changes to this bug.