842318 - [HOMESCREEN] If you try to swipe right from the last desktop in edit mode, icons stop vibrating

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Tested in unagi with Gecko-0ecc076.Gaia-4164424.

STR:
1-Longtap an icon (e.g. HERE maps) to enter edit mode
2-Swipe right to the last desktop
3-Swipe again

Expected result --> You can´t go to the right and icons are still vibrating, because you´re still in edit mode

Actual result --> Icons stop vibrating

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

This patch applies when users try to swipe but the new and current pages are the same, I mean, there is not navigation to other page. Homescreen works fine when pages were translated because it listens for transitionend event but in edge cases e.g. swipe from rigth to left on the last page on the grid there is not movement so not transitionend. What happen? Missed vibrating edit mode and dead listeners

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

It is not unreasonable to expect a user to get back into edit mode by holding down an icon again. Not blocker.

Comment 3

[Cristian Rodriguez (:crdlc)]

IMHO this bug is not related to that, as far as I understand, the STR are:

1) Go to last page in the grid
2) Enter in edit mode and then icons start jumping
3) Swipe from right to left, obviously, you stay in the last page but icons stop jumping

4) If you swipe from left to right you go to previous page and then icons start jumping again

Comment 4

[Marcelino Veiga Tuimil [:sonmarce]]

(In reply to Lukas Blakk [:lsblakk] from comment #2)
> It is not unreasonable to expect a user to get back into edit mode by
> holding down an icon again. Not blocker.

As Cristian explained in previous comment, it is a different kind of problem, so renominating again...

Comment 5

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/cc59b3290a240ca8ab930b53158a4a6cfcb016dd

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 715391 [details]
Patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: bad experience, maybe users can think that they are not in edit mode 
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch:

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 715391 [details]
Patch v1

This is still not a blocker, unless it's impossible to edit or drag icons in the direction of a screen that *does* exist.  We'll take the fix for this unfortunate glitch as a v1-train uplift.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train@51b35c221ced188428ee78b07e3c022d20dd740f

Comment 9

[rafael.marquez]

The bug is fixed in V1.0.1

Comment 10

[Jason Smith [:jsmith]]

(In reply to rafael.marquez from comment #9)
> The bug is fixed in V1.0.1

Uhh...what? If the bug isn't working now, file a followup. We've already landed the patches here to warrant closing the bug.

Comment 11

[Cristian Rodriguez (:crdlc)]

Rafa wants to say what this bug is reproducible on v1.0.1. Do you want to re-open this one or we should create a follow up? Thanks a lot

Comment 12

[rafael.marquez]

I do not know which is the correct procedure. I want that this bug not be reproduced in v1.0.1

Comment 13

[Cristian Rodriguez (:crdlc)]

FYI it happens only in v1.0.1 branch. Maybe, this old patch would merge on v1.0.1 but I prefer doing a specific patch in order to avoid new bugs.

Comment 14

[David Scravaglieri [:scravag]]

This should not block the realease, we will track it.