842361 - nsIClipboard's clearClipboard doesn't clear the clipboard on Windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jim Mathies [:jimm]]

We call nsBaseClipboard's ClearClipboard to free the internal transferable, but we don't clear the Windows clip board.  This can cause problems when writing tests for things like context menus, which have different state depending on the result of HasDataMatchingFlavors. HasDataMatchingFlavors asks Windows if the clip has the data type.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 715208 [details] [diff] [review]
patch

Review of attachment 715208 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 4

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/efae9ff14662

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/efae9ff14662

Comment 6

[Asa Dotzler [:asa]]

Is there an easy way to test this? If not, I'll let developers verify.