nsIClipboard's clearClipboard doesn't clear the clipboard on Windows

RESOLVED FIXED in mozilla22

Status

()

Core
Widget: Win32
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
mozilla22
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We call nsBaseClipboard's ClearClipboard to free the internal transferable, but we don't clear the Windows clip board.  This can cause problems when writing tests for things like context menus, which have different state depending on the result of HasDataMatchingFlavors. HasDataMatchingFlavors asks Windows if the clip has the data type.
(Assignee)

Comment 1

5 years ago
Created attachment 715207 [details] [diff] [review]
patch
Assignee: nobody → jmathies
(Assignee)

Comment 2

5 years ago
Created attachment 715208 [details] [diff] [review]
patch
Attachment #715207 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #715208 - Flags: review?(netzen)
Comment on attachment 715208 [details] [diff] [review]
patch

Review of attachment 715208 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #715208 - Flags: review?(netzen) → review+
https://hg.mozilla.org/mozilla-central/rev/efae9ff14662
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22

Comment 6

5 years ago
Is there an easy way to test this? If not, I'll let developers verify.

Updated

5 years ago
Depends on: 883554
You need to log in before you can comment on or make changes to this bug.