842383 - text and icon in attendees dialog need more spacing

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Vincent (caméléon)]

Attachment: screenshot of the issue

It is currently quite hard to read the invite attendees caption, it would be better with more spacing. See the attached sreenshoot for a better overview of my proposal.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

For this issue I think we should just space the three columns evenly within the remaining space, this can be done with the flex attribute.

Comment 2

[Sparsh Paliwal [:discoman]]

https://dxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog-attendees.xul#159

i commented this <hbox> because it was collapsed already and was occupying unnecessary space, but on adding flex attribute to the grid above this <hbox> it is not resulting in any change.I also tried doing some wild things, just to see would any of the change in the code would change any thing so i added new columns and corresponding spacers in rows that i guess should have made some change but it too didn't work.

Comment 3

[Sparsh Paliwal [:discoman]]

Attachment: added space between text and icon

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8561536 [details] [diff] [review]
added space between text and icon

Review of attachment 8561536 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, r=philipp. Could you do me one favor and upload the patch again with the commit message like "Bug NNNN - summary of this bug. r=philipp", carry forth the r+ of the patch and set checkin-needed in the keyword field?

Comment 5

[Sparsh Paliwal [:discoman]]

Attachment: bug842383.diff

Done!!!!

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/9493fbd94f6a