Last Comment Bug 842383 - text and icon in attendees dialog need more spacing
: text and icon in attendees dialog need more spacing
Status: RESOLVED FIXED
[invite attendees dialog]
:
Product: Calendar
Classification: Client Software
Component: Dialogs (show other bugs)
: Lightning 1.9
: x86_64 Windows 7
-- minor (vote)
: 4.0.0.1
Assigned To: Sparsh Paliwal [:discoman]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-18 13:45 PST by Vincent (caméléon)
Modified: 2015-02-20 06:19 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
screenshot of the issue (88.38 KB, image/png)
2013-02-18 13:45 PST, Vincent (caméléon)
no flags Details
added space between text and icon (5.80 KB, patch)
2015-02-09 11:22 PST, Sparsh Paliwal [:discoman]
philipp: review+
Details | Diff | Splinter Review
bug842383.diff (5.82 KB, patch)
2015-02-19 23:31 PST, Sparsh Paliwal [:discoman]
sparshpaliwal123: review+
Details | Diff | Splinter Review

Description User image Vincent (caméléon) 2013-02-18 13:45:15 PST
Created attachment 715234 [details]
screenshot of the issue

It is currently quite hard to read the invite attendees caption, it would be better with more spacing. See the attached sreenshoot for a better overview of my proposal.
Comment 1 User image Philipp Kewisch [:Fallen] 2015-01-30 02:12:27 PST
For this issue I think we should just space the three columns evenly within the remaining space, this can be done with the flex attribute.
Comment 2 User image Sparsh Paliwal [:discoman] 2015-02-06 20:53:16 PST
https://dxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog-attendees.xul#159

i commented this <hbox> because it was collapsed already and was occupying unnecessary space, but on adding flex attribute to the grid above this <hbox> it is not resulting in any change.I also tried doing some wild things, just to see would any of the change in the code would change any thing so i added new columns and corresponding spacers in rows that i guess should have made some change but it too didn't work.
Comment 3 User image Sparsh Paliwal [:discoman] 2015-02-09 11:22:31 PST
Created attachment 8561536 [details] [diff] [review]
added space between text and icon
Comment 4 User image Philipp Kewisch [:Fallen] 2015-02-19 11:21:08 PST
Comment on attachment 8561536 [details] [diff] [review]
added space between text and icon

Review of attachment 8561536 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, r=philipp. Could you do me one favor and upload the patch again with the commit message like "Bug NNNN - summary of this bug. r=philipp", carry forth the r+ of the patch and set checkin-needed in the keyword field?
Comment 5 User image Sparsh Paliwal [:discoman] 2015-02-19 23:31:39 PST
Created attachment 8566976 [details] [diff] [review]
bug842383.diff

Done!!!!

Note You need to log in before you can comment on or make changes to this bug.