text and icon in attendees dialog need more spacing

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Dialogs
--
minor
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: Vincent (caméléon), Assigned: discoman)

Tracking

Lightning 1.9
4.0.0.1
x86_64
Windows 7

Details

(Whiteboard: [invite attendees dialog])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 715234 [details]
screenshot of the issue

It is currently quite hard to read the invite attendees caption, it would be better with more spacing. See the attached sreenshoot for a better overview of my proposal.
Whiteboard: [invite attendees dialog]
For this issue I think we should just space the three columns evenly within the remaining space, this can be done with the flex attribute.
Assignee: nobody → sparshpaliwal123
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
https://dxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog-attendees.xul#159

i commented this <hbox> because it was collapsed already and was occupying unnecessary space, but on adding flex attribute to the grid above this <hbox> it is not resulting in any change.I also tried doing some wild things, just to see would any of the change in the code would change any thing so i added new columns and corresponding spacers in rows that i guess should have made some change but it too didn't work.
(Assignee)

Comment 3

2 years ago
Created attachment 8561536 [details] [diff] [review]
added space between text and icon
Attachment #8561536 - Flags: review?
Attachment #8561536 - Flags: review? → review?(philipp)
Comment on attachment 8561536 [details] [diff] [review]
added space between text and icon

Review of attachment 8561536 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, r=philipp. Could you do me one favor and upload the patch again with the commit message like "Bug NNNN - summary of this bug. r=philipp", carry forth the r+ of the patch and set checkin-needed in the keyword field?
Attachment #8561536 - Flags: review?(philipp) → review+
(Assignee)

Comment 5

2 years ago
Created attachment 8566976 [details] [diff] [review]
bug842383.diff

Done!!!!
Attachment #8566976 - Flags: review+
Attachment #8566976 - Flags: checkin?
Attachment #8566976 - Flags: checkin?
Keywords: checkin-needed
Attachment #8561536 - Attachment is obsolete: true

Comment 6

2 years ago
https://hg.mozilla.org/comm-central/rev/9493fbd94f6a

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.0
You need to log in before you can comment on or make changes to this bug.