Closed Bug 842442 Opened 11 years ago Closed 11 years ago

Return NO_DEVICES_FOUND error when only video or only audio is requested with no suitable device available

Categories

(Firefox :: Site Permissions, defect, P1)

Product:
Firefox
Component:
Site Permissions
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 22
Tracking Flags:
Tracking Status
firefox20 + fixed
firefox21 + fixed
firefox22 --- verified

People

(Reporter: jsmith, Assigned: dao)

References

Details

(Whiteboard: [getUserMedia][blocking-gum+])

Attachments

(1 file)

patch
3.69 KB, patch
Dolske
: review+
bajaj
: approval-mozilla-aurora+
bajaj
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Steps:

1. Go to http://mozilla.github.com/webrtc-landing/gum_test.html
2. With only an integrated mic available, request video

Expected:

NO_DEVICES_FOUND should be reported - which means an error callback fires with that error code.

Actual:

No error callback is fired and NO_DEVICES_FOUND is fired.

Additional Notes:

Similar reproduction steps shows this also reproduces when requesting audio with a camera only available.
Blocks: 827145
status-firefox20: --- → affected
status-firefox21: --- → affected
tracking-firefox20: --- → ?
tracking-firefox21: --- → ?
Whiteboard: [getUserMedia][blocking-gum+]
Dao/Dolske: we'll want to fix this soon since we'll need to uplift any fix to Beta

-> Dolske for now at least
Assignee: nobody → dolske
Severity: normal → critical
status-firefox22: --- → affected
Priority: -- → P1
Whiteboard: [getUserMedia][blocking-gum+] → [getUserMedia][blocking-gum+][webrtc-uplift]
Severity: critical → normal
Component: WebRTC: Audio/Video → General
Product: Core → Firefox
QA Contact: jsmith
Attached patch patch — — Splinter Review 
Assignee: dolske → dao
Status: NEW → ASSIGNED

        Attachment #717052 -
        Flags: review?(dolske)

    
    

    
  
Comment on attachment 717052 [details] [diff] [review]
patch

Thanks!

        Attachment #717052 -
        Flags: review?(dolske) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/cd4402b41864
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Summary: getUserMedia - Request access to video with mic only or audio with video only - no error callback is fired with an error code → Return NO_DEVICES_FOUND error when only video or only audio is requested with no suitable device available

    
    

    
  
Needs to be uplifted to Aurora and Beta.
Keywords: verifyme
QA Contact: jsmith

    
  

          status-firefox22:
          fixed → ---
Target Milestone: --- → Firefox 22

    
    

    
  
Verified on 2/25 nightly build. Good for uplift.
Status: RESOLVED → VERIFIED
Keywords: verifyme

    
    

    
  
Comment on attachment 717052 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 827145 (incomplete fix)

User impact if declined: Some common error cases (no camera but have a mic) won't return an error that the application can use

Testing completed (on m-c, etc.): on m-c, Verified

Risk to taking this patch (and alternatives if risky): very low.

String or UUID changes made by this patch: none

        Attachment #717052 -
        Flags: approval-mozilla-beta?

        Attachment #717052 -
        Flags: approval-mozilla-aurora?

        Attachment #717052 -
        Flags: approval-mozilla-beta?

        Attachment #717052 -
        Flags: approval-mozilla-beta+

        Attachment #717052 -
        Flags: approval-mozilla-aurora?

        Attachment #717052 -
        Flags: approval-mozilla-aurora+

    
    

    
  
https://hg.mozilla.org/releases/mozilla-aurora/rev/a39dd26ed4f2

This doesn't apply cleanly to beta without bug 835892 (conflicts in webrtcUI.jsm). I couldn't get ahold of anyone on IRC, so holding off on the beta uplift for now.

          status-firefox21:
          affected → fixed

          status-firefox22:
          --- → fixed
Whiteboard: [getUserMedia][blocking-gum+][webrtc-uplift] → [getUserMedia][blocking-gum+]

    
    

    
  
Verified as fixed on Firefox 22 beta 2:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20100101 Firefox/22.0
Build ID: 20130521223249

          status-firefox22:
          fixed → verified
Component: General → Device Permissions

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: