842471 - [b2g-bluetooth] Invalid value type in BluetoothDevicePropertiesRunnable()

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

I/Gecko   (  497): [Parent 497] WARNING: Failed to get device properties: file /workspace/mozilla-central/dom/bluetooth/linux/BluetoothDBusService.cpp, line 1377
I/Gecko   (  497): [Parent 497] WARNING: Getting properties failed!: file /workspace/mozilla-central/dom/bluetooth/linux/BluetoothDBusService.cpp, line 2021

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

In BluetoothDevicePropertiesRunnable, assuming that the type of BluetoothValue should be an array of BluetoothNamedValue, and it should not be used for handling event "DeviceCreated" with the input of an nsString.

Since we're going to remove this event from nsIDOMBluetoothAdapter.idl and no need to get device properties here, we don't forward this event to BluetoothAdapter. However, the implementation in BluetoothAdapter.cpp will be removed after the idl is revised.

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Do not get device properties and forward to BluetoothAdapter

Comment 3

[Mozilla RelEng Bot]

Try run for 0926e59777cc is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=0926e59777cc
Results (out of 18 total builds):
    success: 12
    warnings: 5
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-0926e59777cc

Comment 4

[Mozilla RelEng Bot]

Try run for 4e70eb5605bd is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=4e70eb5605bd
Results (out of 14 total builds):
    warnings: 13
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-4e70eb5605bd

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final patch: Do not get device properties and forward to BluetoothAdapter, r=echou

Comment 6

[Mozilla RelEng Bot]

Try run for 000903522b59 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=000903522b59
Results (out of 18 total builds):
    success: 17
    warnings: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-000903522b59

Comment 7

[Mozilla RelEng Bot]

Try run for 3f018da666b9 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=3f018da666b9
Results (out of 14 total builds):
    success: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-3f018da666b9

Comment 8

[Gina Yeh [:gyeh] [:ginayeh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/462b9501603d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/462b9501603d