The default bug view has changed. See this FAQ.

when not using relative path, local modules have lower priority than sdk modules specified into mapping file

RESOLVED FIXED in 1.14

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
1.14

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
whimboo just hit that issue while repacking memchaser with SDK 1.13.x
We have a regression of the mapping feature that allows to make addon to work with new module layout.

Given an addon with a local memory module:

  const memory = require("memory");

Will return `sdk/deprecated/memory` instead of `./memory`.
I think this definitely warrants inclusion in 1.14 (especially if it gets fixed sometime this week).

If we're still targeting 1.14 for a mass repack, this would probably help us successfully repack addons much more easily.
Target Milestone: --- → 1.14
(Assignee)

Comment 2

4 years ago
Created attachment 715424 [details]
Pull request 800
Assignee: nobody → poirot.alex
Attachment #715424 - Flags: review?(rFobic)
(Assignee)

Comment 3

4 years ago
Henrik, it would be really handy if you can confirm that it actually allows you to repack memchase without any modification.
Attachment #715424 - Flags: review?(rFobic) → review-
Sorry, that I haven't had time to check this yesterday. Given r- now I assume no testing is necessary at this point?
(Assignee)

Updated

4 years ago
Attachment #715424 - Flags: review- → review?(rFobic)
Attachment #715424 - Flags: review?(rFobic) → review+

Updated

4 years ago
Priority: -- → P1

Comment 5

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/9db0339fe6e13e9828aa3961e9360dcfc2f69323
Bug 842486 - Fix priority of modules matched by mapping file.

https://github.com/mozilla/addon-sdk/commit/7d4b7d353cc3485e39ff425e86a50428deb2e70c
Merge pull request #800 from ochameau/mapping-priority

Bug 842486 - Fix priority of modules matched by mapping file. r=@gozala
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.