842486 - when not using relative path, local modules have lower priority than sdk modules specified into mapping file

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

whimboo just hit that issue while repacking memchaser with SDK 1.13.x
We have a regression of the mapping feature that allows to make addon to work with new module layout.

Given an addon with a local memory module:

  const memory = require("memory");

Will return `sdk/deprecated/memory` instead of `./memory`.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think this definitely warrants inclusion in 1.14 (especially if it gets fixed sometime this week).

If we're still targeting 1.14 for a mass repack, this would probably help us successfully repack addons much more easily.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 800

Comment 3

[Alexandre Poirot [:ochameau]]

Henrik, it would be really handy if you can confirm that it actually allows you to repack memchase without any modification.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sorry, that I haven't had time to check this yesterday. Given r- now I assume no testing is necessary at this point?

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/9db0339fe6e13e9828aa3961e9360dcfc2f69323
Bug 842486 - Fix priority of modules matched by mapping file.

https://github.com/mozilla/addon-sdk/commit/7d4b7d353cc3485e39ff425e86a50428deb2e70c
Merge pull request #800 from ochameau/mapping-priority

Bug 842486 - Fix priority of modules matched by mapping file. r=@gozala