842504 - [FTU] Language screen background image and first item top

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Sam Joch [:samjoch]]

Attachment: Screenshot

* When scrolling on Languages list the background is scrolled too.
* Also remove the first item top header because there it creates a line on top of background.

-- 

* Language screen background image should be fixed.
* First item top border should be 0.

Comment 1

[Sam Joch [:samjoch]]

Attachment: Patch

Comment 2

[Sam Joch [:samjoch]]

Attachment: Patched screenshot

Comment 3

[Patryk Adamczyk [:patryk] UX]

Looks good. Push it in.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 5

[Fernando Campo (:fcampo)]

Comment on attachment 715948 [details]
Patch

Looks good for me, so r+ with changes commented on github commit

Comment 6

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/8d26f01ad9096f62e14ff851f1251abfbabe165a

Comment 7

[Sam Joch [:samjoch]]

Comment on attachment 715948 [details]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: Will see a scrollbar on the FTU Language screen 
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): low risk only css changes
String or UUID changes made by this patch: -

Comment 8

[Fernando Campo (:fcampo)]

(In reply to Sam Joch [:samjoch] from comment #6)
> https://github.com/mozilla-b2g/gaia/commit/
> 8d26f01ad9096f62e14ff851f1251abfbabe165a

Hi Sam. I see that you kept the 'fixed' property, and didn't stated position '0 0' for the background image as I asked on the comments.
That caused the image not being in the top of the section, part of it is hidden behind the header.

So, unless I'm missing something, I wouldn't recommend to uplift this at all. Actually my recommendation would be to take out the commit from master, and fix it before merge.

If that's more complicated than I think, I will open a new regression bug then.

Comment 9

[Sam Joch [:samjoch]]

Attachment: fixed vs 0 0

Actually i wanted the background image to be fixed so if their are many language the image would stay. 

I attached both versions of the screen. With the fixed background, the first language will not be readable. What do you think ?

Comment 10

[Fernando Campo (:fcampo)]

Oh, I see what you mean.

Then I think I'm gonna involve UX in here (passing the ball, I walk away while whistling :D), so they can explain better what they want to achieve in here, if they'd rather fixed, scroll, or less languages in the screen.

Comment 11

[Fernando Campo (:fcampo)]

Ok, talked offline with Victoria, and she agrees that fixed is better, even if we hide part of the image, so we are good to go :)

Thanks Sam, and sorry for the delay I created

Comment 12

[Victoria Gerchinhoren [:vicky]]

Please, place the image as it is in the left hand example of this attachment:

https://bug842504.bugzilla.mozilla.org/attachment.cgi?id=733280

That will leave room for the languages list without compromising legibility

Thanks!
Victoria

Comment 13

[Angela Hubenya]

The background stays put when the languages are scrolled in the Master build. 

Unagi Build ID: 20130404030955
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/mozilla-central/rev/c232bec6974d
Gaia: 29660ec0a4ad7c90d22e33852e1601d45f781e03
 


But the whole thing scrolls on the v1 train. 

Unagi Build ID: 20130404070202
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/da523063aa7b
Gaia: a845be046c5d3cb077e3c78f963ca5c079e7ab3d

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I believe that the fixed bubbles is one of the intended fixes.

marking as verified

Master build : 2013-04-05-03-05-43
name="mozilla-central" revision="55f9e3e3dae7"  
name="integration/gaia-central" revision="2005e026bdae"
"gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550"
"gaia.git" revision="15468abcba0dd2549f0c102df887

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 8d26f01ad9096f62e14ff851f1251abfbabe165a as:
v1-train: 34bbdd7d0265b76bfe1e7c2f5722c303f6482328