Closed Bug 842528 Opened 11 years ago Closed 7 years ago

Bookmarks tags selector listbox is slow to populate

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Version:
18 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: wagle, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20130201065344

Steps to reproduce:

Create 9407 bookmarks and something like 1000 tags.




Actual results:

Popup the bookmarks editor.  Now takes 3-5 seconds.  And it adds up.  I spent several hours today doing what should have taken me an hour.


Expected results:

This is about 3-5 times longer than what it used to take.

Seems related (maybe) to https://bugzilla.mozilla.org/show_bug.cgi?id=490512
I suspect the 1000 tags are mostly involved here.
Would you mind testing a separate profile without the tags?

What's your system specs? Do you have add-ons acting on bookmarks/history?
Component: Untriaged → Bookmarks & History
Summary: Bookmark editor is slow popping up → The Library takes seconds to open
I've tried to use Firefox sync and Xmarks to copy the bookmarks to another system, with no luck.  Any suggestions as to how to copy the thing and/or to delete 1000 tags in less than 12 hours?
Oh, I use tagsieve to query the tags.
Just create a new profile, copy places.sqlite file from your profile to the new one, then remove the tags in the Library of this new testing profile (select Tags in the left pane, select all in the right page and delete). If the Library is then 
fast to open, it's likely we should work on improving the tags performances.
Remember to backup the profile, for any eventual dataloss!
once done you can remove this testing profile and all of its files.

Another experiment you may do before, is to check if in Safe Mode the Library takes less time to open, if so it's possible tagSieve or another add-on is related to the slowdown.

Finally, are all of your 9 thousands bookmarks in a single folder or spread around in multiple folders?
Is the bookmarks menu fast to open?
Same thing without tagsieve enabled.

About 100-300 bookmarks are in various folders.  The remaining 9176 are in the "unsorted bookmarks".  Trying various things now.
Oh I see.  I'm using Editboookmarkplus to resize the editor AND to select "display all tags".  Displaying all the tags takes seconds now to setup.
what does "display all tags" do?
Its the "Show all tags" button to the right of the tag entry field.
ah ok, so when opening the Library a bookmark is automatically selected and that field is opened and populated?
Strange though, opening the Library sets it to All Bookmarks that doesn't have a tags selector. Plus I cannot find an option to always show all tags in Editbookmarkplus...
Btw, if you disable this option is the slowdown solved?

I suspect there could be the same issue we hit with the new downloads view, large listboxes are slow and the tags selector is a listbox.
Its a large listbox, half the size of my screen (my tags are many and are up to 50 chars wide).  I hacked editbookmarkplus in the obvious way to grow the tags instead of the folders list. Editbookmarkplus has a "delay" option to show the skeleton of the popup before the contents.
(In reply to Perry Wagle from comment #10)
> I hacked editbookmarkplus in the obvious way to grow the
> tags instead of the folders list.

I suspect that hack is causing the tags list to expand even if it's hidden, that means even on All Bookmarks, and the time it takes to do that sums up to the normal time needed to open the Library, causing those 3-5 seconds wait time.

So, provided we should investigate perf improvements for this listbox, what happens if you disable this add-on, how does the Library open time improve?
When i disabled the addon, I couldn't really test the functionality, since both the bookmarks editor popup window was tiny, and it remained too tiny to display the full width of the tag when "Show all tags" was pressed.  Pressing Show all tags took maybe 2-3 seconds.  I can supply my mods to editbookmarkplus if you are interested.

I'm feeling like I should pull out the resizer from the rest of the stuff in editbookmarkplus, and see if it can be made more efficient.  I think it presses the button logically (to get all the callbacks, or something).
So opening the Library takes a couple seconds, and then clicking on Show all tags takes another couple seconds? A stopwatch measure will be enough for me.
Testing with Editbookmarks enabled is complicated by its extensions.editbookmarkplus.popupshowndelay variable, which is 200 by default.
If set to 0, the popup shows up all at once in 3-5 seconds.  If set to 200, then the popup shows a skeleton after 1 second, then fills in in 2-4 seconds.
oops, looks like I misinterpreted this bug, by bookmarks editor you meant the panel/properties, not the Library. So this is not at all related to bug 490512.

So I care about the time it takes to open the same popup with Editbookmarkplus disabled.
Summary: The Library takes seconds to open → The Edit Bookmark panel takes seconds to open
Testing without Editbookmarks enabled is complicated by the tiny size of the popup.  My testing setup is the same places.sqlite file in a brand new instance with no addon's at all.  In that, the initial popup takes 1/2 a second, and the show all tags takes about 1-2 seconds, but shows much less of the width of the tags, and not as many tags.

What do you mean by library?  The "Show all bookmarks?".
By the way, the tiny size of the bookmark editor is a long long standing bug.  8)
(In reply to Perry Wagle from comment #16)
> In that, the initial popup takes 1/2 a
> second, and the show all tags takes about 1-2 seconds, but shows much less
> of the width of the tags, and not as many tags.

Ok, I will change this bug to improve the performance of filling up the tags selector.

1-2 seconds it's still a lot, could be there's more. What's your computer specs (mostly CPU and memory) just for comparison?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: The Edit Bookmark panel takes seconds to open → The tags selector listbox is slow to populate
MacBookPro, 2.66 GHz Intel Core i7, 8GB 1067 MHz DDR3, lots of disk left.
Summary: The tags selector listbox is slow to populate → Bookmarks tags selector listbox is slow to populate
Seems not to have been an issue since way back then.  Should this bug be closed?
If the time is not satisfying, I'm glad to close it.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
ehr, sorry, s/not/now/
You need to log in before you can comment on or make changes to this bug.