842541 - Have minimum support for debugging loading errors in LazyLoader

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jose Manuel Cantera]

It would be good to have a minimum support in LazyLoader for debugging load errors. Proposal: window.console.error when something cannot be loaded (onload error).

Comment 1

[Jose Manuel Cantera]

Attachment: Pointer to GH PR

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 715482 [details]
Pointer to GH PR

Hi Jose, I'm sorry, but to be perfectly honest - I just don't think this is necessary. My reasoning:

- It's slower due to extra calls/function definitions. Sure, we're only talking a few lines of code - but I don't see any value in adding this extra code/complexity.
- It provides no value in production mode, and functionality is already handled by most developer consoles.
- This should be handled by the platform, and not gaia.

I'm going to pass on this review for now, but if you get sufficient buy-in from other developers, I could go along with them. It would best to check with Vivien and Jim Porter (as he did the original communications implementation). I'll add Jim for feedback here as well.

Comment 3

[Jim Porter (:squib)]

Comment on attachment 715482 [details]
Pointer to GH PR

I don't think this is necessary either. Using the LazyLoader isn't fundamentally different from typing <script> tags into the HTML. We don't set onerror notifications for non-LazyLoaded scripts, which are just as prone to error as using the LazyLoader (assuming the LazyLoader is bug-free).

If logging bad loads is important, we should be doing it in such a way that it covers non-LazyLoaded resources as well. Otherwise, we're not logging around 50% of the potential errors.