842558 - Tapping status bar rapidly causes utility tray to fully slide out

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

(Tested in B2G desktop, Unagi and GeeksPhone (harder to reproduce here))

At the moment we'll always add the 'utility-tray' class to the screen onTouchStart. This causes the utility tray to appear and disappear immediately when only doing a touch start and no drag. The disappearing is not immediate because there is also an animation, tapping again while in this animation might cause the utility tray to open completely, which is really weird and caused me to accidentally open the tray a couple of times already.

Desired behaviour should be to only show the utility tray when actually doing the touch move rather than the touch start.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Proposed patch to only show the utility tray on drag

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 715493 [details] [diff] [review]
Proposed patch to only show the utility tray on drag

r+, but please squash all commits into one commit with a bug number in the commit comment.

I would like to get UX feedback on the behavior before this is merged. I suspect the "bug" you see is intentional visual/interaction hint.

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

Hi Tim, thanks for the r+. I doubt whether this was on purpose, but for the UX feedback:

By having this behaviour we also open up for other weird behaviour, like not bubbling events through if you have a click handler on top of screen in your apps, and you get visual feedback when tapping that doesnt hint an activity bar on top.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Who do I need to ping for UX feedback on this?

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

Josh, can you elaborate on this?

Comment 6

[Jan Jongboom [:janjongboom] (inactive)]

Tim, can you ping someone about this issue for feedback?

Comment 7

[Evelyn Hung]

Tim is on vacation now. I think Josh is the right person to provide some feedback here. Try to ping him on IRC.

Comment 8

[Josh Carpenter [:jcarpenter]]

Hi there, sorry for the slow response. 

(In reply to janjongboom from comment #0)
> Desired behaviour should be to only show the utility tray when actually
> doing the touch move rather than the touch start.

Current behavior is correct. We want to make the utility tray more discoverable, so we provide a little hint that it exists when the user taps the status bar. However you are correct that tapping repeatedly should not cause the tray to open. It should instead simply repeat the animation. 

The scope of this bug is to fix that glitch, but keep the rest of the behavior intact. 

Updated bug name to match new scope.

Comment 9

[Josh Carpenter [:jcarpenter]]

Comment on attachment 715493 [details] [diff] [review]
Proposed patch to only show the utility tray on drag

-'ing patch, per feedback in most recent commment.

Comment 10

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 715493 [details] [diff] [review]
Proposed patch to only show the utility tray on drag

I have changed the behavior of this patch. It still shows the utility tray hint but the double tapping to open the tray has been patched. Please re-r?.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 715493 [details] [diff] [review]
Proposed patch to only show the utility tray on drag

This is generally correct. Thanks for finding the cause of the glitch, which cause by the fact we didn't reset the values properly after the interaction.

Would you fix all that together?
-- remove the comment on L125-127
-- reset both startY and lastY to undefined
-- remove the startX -- it's not used anywhere

Thanks

Comment 12

[Jan Jongboom [:janjongboom] (inactive)]

Fixed. Ready to merge.

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/4656bf49b15fe91cb3b53854a1eb4c39bc11d3ed