84263 - View sites that can/cannot display images menu item not working.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Judson Valeski]

steps to repro.

1. Tasks->Privacy/Security->Image Manager->View sites that can....
2. a dialog comes up w/ the Cookie tab having focus.

expected behavior is that the Image sites tab is the focused tab.

Comment 1

[Stephen P. Morse]

Looks like something changed in the infrastructure.  Attaching patch.

Comment 2

[Stephen P. Morse]

Attachment: Patch to hide unneeded tabs

Comment 3

[Stephen P. Morse]

cc'ing matt for review, alecf for superreview

Comment 4

[Judson Valeski]

this isn't working for me on linux. I'm clobbering my build to be sure it's my
problem rather than the patch. I'll report back when the build is done.

Comment 5

[Stephen P. Morse]

FWIW, this got broken with maolson's changes on 17 April 2001.  He changed the 
id of an element from "tabcontrol" to "tabbox" in the xul file, but changed the 
reference to it in the js file from "tabcontrol" to "tabcontrols".

Comment 6

[Stephen P. Morse]

Well if that patch isn't working for you, I have a much simpler one.  It merely 
corrects the error that maolson made without attempting to do any other cleanup.  
I'll post that for you to try.

Comment 7

[Stephen P. Morse]

Attachment: Minimum change to correct error introduced on April 17

Comment 8

[Judson Valeski]

whoops. I'm an idiot. the first patch works fine. CookieViewer.js is in the
wrong dir (should be in the cookie dir). I applied the patch and rebuilt cookies
:-/. After rebuilding the correct dir, this patch works great. r=valeski

Comment 9

[Paul Chen]

nav triage team:

Not a stopper, marking p3 and mozilla0.9.3

Comment 10

[Stephen P. Morse]

But it's a regression and an embarrasement, and we have a very simple patch for 
it.  Do you really want me not to fix it.

Comment 11

[Alec Flett]

sr=alecf

Comment 12

[timeless]

r=timeless for either

Comment 13

[Asa Dotzler [:asa]]

a= [e-mail] for checkin of the minimal patch to the trunk.
(on behalf of drivers)

Comment 14

[Stephen P. Morse]

Fix checked in.