842636 - Story - Pin and un-pin a page to Windows Start

Status: VERIFIED FIXED

(Tracking Graveyard :: Metro Operations, defect, P2)

Description

[Asa Dotzler [:asa]]

Attachment: UC-6-4 Pin and un-pin a page to Windows Start

Comment 1

[Marco Mucci [:MarcoM]]

Thanks Asa.  What Epic is this story related to?

Comment 2

[Brian R. Bondy [:bbondy]]

Asa: To answer the question in the story about if we can type anything, yes I think you can type anything. I tried entering a lot of illegal filename characters in the name and it still works correctly.


Asa for this part:
> The user taps the Pin site button in the app bar and sees a Flyout directly 
>above and to the left of the button with a preview of the site tile and a text 
> entry field containing the name of the page, and a Pin to Start button. 
> (see http://cl.ly/image/2L0f0o3J2S0x)

I think we should break out having a preview of sites for secondary tiles into its own story bug.  It's much too complicated for this story and I think really low priority.  Using the main app tile and custom text which is implemented now I think is enough for v1.  This story should remain open because of the linked bug.

Comment 3

[Asa Dotzler [:asa]]

I'm OK with splitting out the site-specific tile work into a new story. I'll do that now. I'll have to think a bit more about whether or not we need that story in v1.

QA note: This story no longer requires a site-specific tile for completion. The Firefox logo in secondary tiles is sufficient.

Comment 4

[Asa Dotzler [:asa]]

(In reply to Asa Dotzler [:asa] from comment #3)
> I'm OK with splitting out the site-specific tile work into a new story. I'll
> do that now. I'll have to think a bit more about whether or not we need that
> story in v1.
> 
> QA note: This story no longer requires a site-specific tile for completion.
> The Firefox logo in secondary tiles is sufficient.

I created Bug 849382 - Story - Site icons in secondary tiles which is blocked by work Bug 847677 - Work - Pin to start should use websites favicon if it exists and not default icon when Nightly is set as the default browser.

Comment 5

[Asa Dotzler [:asa]]

This probably needs to come out of on hold. For v1, we just need to figure out blocking bug 831514 and we can close out this story.

Comment 6

[Brian R. Bondy [:bbondy]]

I'll create a debug builds with extra logging for KWierso in it6 to figure this out.

Comment 7

[Brian R. Bondy [:bbondy]]

Hey Kwierso could you try tomorrow's nightly and let me know if you still have a problem? Thanks!

Comment 8

[Brian R. Bondy [:bbondy]]

Kwierso replied on IRC that it's working now

Comment 9

[Marco Mucci [:MarcoM]]

Temporary reopening to add it.  Will resolve it again right after.

Comment 10

[Marco Mucci [:MarcoM]]

For Kamil to test and verify.

Comment 11

[raymond [:retornam] (inactive)]

verified fixed  using build  http://hg.mozilla.org/mozilla-central/rev/9d8977cbbfc6
(2013-04-28)

I'm able to pin and unpin a webpage to Windows Start

Comment 12

[Brian R. Bondy [:bbondy]]

Found an issue when using this button for the start page for it8 testing using today's nightly. Posted in Bug 881874.

Comment 13

[Brian R. Bondy [:bbondy]]

Yuan said this will be addressed in bug 873251

Comment 14

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:25.0) Gecko/20130707 Firefox/25.0
Build ID: 20130707031138

WFM for iteration-9
Tested on Windows 8.1 preview using latest nightly build from ftp://ftp.mozilla.org/pub/firefox/nightly/2013/07/2013-07-07-03-11-38-mozilla-central/
I used same steps given in user story.
I am getting expected result.