842641 - dxr.mozilla.org no longer shows hgblame links

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Joshua Cranmer [:jcranmer]]

This is a known regression, caused by hglib not working properly on the buildbots.

Comment 1

[Joshua Cranmer [:jcranmer]]

Well, I can't f? without a patch, so I'll needinfo? instead.

I've started work on a plugin called "omniglot" which is designed to replace the current hg plugin:
https://github.com/jcranmer/dxr/commit/82728124691f8358e388ba6c2037fa581ce2a482

That commit should support links for hg.mozilla.org and github (my small repositories all seem to be github ones, go figure), as well as supporting cases where there are multiple repositories in a tree or where the tree itself is a subdir of the repository (e.g., js/src as a tree).

Comment 3

[Erik Rose [:erik][:erikrose]]

Review comments:

* Typical style stuff: PEP 8 naming & import ordering
* Consistency: sometimes you say VCS, sometimes Vcs
* See also PEP 257 for docstrings.

The design looks reasonable. We can refactor and nitpick once we get it working. You're going to make a lot of people very happy!

Comment 5

[Joshua Cranmer [:jcranmer]]

Attachment: Add the omniglot plugin, which can provide links to blame for both hg and git.

This changeset is a partial fix for bug 842641.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/ca2150da02f5e2b23ee02d8493293aae53d170cf
Add the omniglot plugin, which can provide links to blame for both hg and git.

This changeset is a partial fix for bug 842641.

--HG--
extra : rebase_source : d99e59def249fe23ff99bab49c783e6b791e3752

Comment 7

[Joshua Cranmer [:jcranmer]]

Looks like dxr.mozilla.org needed no config change to get the links appearing this morning, so I declare this fixed!

Comment 8

[:Irving Reid (No longer working on Firefox)]

Scope creep, but it would be extra nice if the panel with the blame links floated in the top right of the window so that one doesn't need to scroll back to the top of the page for them...

Comment 9

[Georg Fritzsche [:gfritzsche]]

The blame links work with middle-click and right-click->"Open in new tab", but left-click doesn't cause navigation (some onclick handler attached here?).

Comment 10

[Erik Rose [:erik][:erikrose]]

Fixing the blame link in bug 920131.