842649 - Remove custom statement cache and use mozStorage's statement cache

Status: RESOLVED WORKSFORME

(Core :: Storage: IndexedDB, defect, P5)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

IndexedDB started caching statements before it was cool but now there's a generic mechanism in moz storage. We shouldn't need two statement caching mechanisms.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Following the LSNG work, IDB's caching implementation was factored out into https://searchfox.org/mozilla-central/source/dom/quota/CachingDatabaseConnection.h and it is likely not suitable for upstreaming into mozStorage based on the tight integration with QM_TRY and the DOM: LWS team pointer guidelines which have not been adopted by mozStorage and are likely not something Places wants to adopt.

That said, appropriate use of and unification with mozStorage abstractions has happened, for example, mozStorageStatementScoper is used.