84265 - XBL clean up issue in autocomplete popup (formerly crasher).

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P4)

Description

[John Morrison]

Edited comments from bug http://bugzilla.mozilla.org/show_bug.cgi?id=83753

------- Additional Comments From Mike Pinkerton 2001-06-04 12:02 -------

i tracked this down to my checkin to fix the previous topcrasher, and while it
shouldn't crash, this code shouldn't be getting called.

it happens that if you backspace fast enough, the XBL doesn't call
nsPopupBoxObject::DestroyPopup(). This trips my code, which fires if the popup
is destroyed but it hasn't correctly unregistered. It is getting destroyed as a
result of some content node being removed from JS/XBL.

--> hewitt. I think this is his baby. I'll add a null check to the 
popupSetFrame
where it's crashing so my failsafe continues to work.


------- Additional Comments From Mike Pinkerton 2001-06-04 12:08 -------

Created an attachment (id=37036)
[patch] don't crash when we're cleaning up after someone, not the real fix


------- Additional Comments From Mike Pinkerton 2001-06-04 12:12 -------

my patch, while not the correct fix, will plug one crash when things go wrong. 
i
left in an assertion so people know when they don't correctly dispose of the
popup. it does seem to stop it from crashing on my win32 build.

can i get r/s/a for this for the trunk? it's a good safety check regardless of
its value to this particular bug. 

[snip]


------- Additional Comments From Mike Pinkerton 2001-06-04 16:59 -------

band-aid on trunk and branch. all yours hewitt! ;)


------- Additional Comments From [e-mail] 2001-06-04 23:37 -------

Can we close this to get verifications and open a new bug for the follow-on 
work?


------- Additional Comments From chris hofmann 2001-06-05 12:28 -------

Marking fixed so it gets verfied on the branch.
Open a new one if needed for additional work needed on the trunk.
Any reason why this should not go on the trunk as a partial fix?


------- Additional Comments From [e-mail] 2001-06-05 14:20 -------

(or was this already checked in on the trunk as well?)


------- Additional Comments From Mike Pinkerton 2001-06-05 14:34 -------

this was checked into both the trunk and the branch (as my comment said
previously). A new bug needs to be opened to hewitt on work that should be done
on the trunk.

Comment 1

[John Morrison]

Mike, does this need a fix for RTM, or is the bandaid sufficient.

Comment 2

[Mike Pinkerton (not reading bugmail)]

i hear the band-aid was sufficient, but really scares me. who knows what weird
state the auto-complete widget is in when this happens.

guess we're not going to have this for the beta, but would like for RTM

Comment 3

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!

Comment 4

[Neil Deakin]

Don't think this applies anymore.