Closed
Bug 842710
Opened 10 years ago
Closed 10 years ago
Identify TabChildGlobals in about:memory/compartment
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: smaug, Assigned: smaug)
Details
(Whiteboard: [MemShrink:P2])
Attachments
(1 file)
5.35 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/?tree=Try&rev=7b92c1f20459
Attachment #715642 -
Flags: review?(justin.lebar+bug)
Updated•10 years ago
|
Whiteboard: [MemShrink]
Comment 1•10 years ago
|
||
It looks like this names the compartments as compartment(inProcessTabChildGlobal?ownedby=http://foobar) ? We do system principal compartments as compartment([System Principal], http://foobar) so perhaps we should stay in line with that and do something like compartment([In-process TabChild], http://foobar) ? I bet njn has an opinion too. :)
Assignee | ||
Comment 2•10 years ago
|
||
TabChildGlobal use system principal, so they should have [System Principal]
Assignee | ||
Comment 3•10 years ago
|
||
and http://... doesn't make sense. TabChildGlobals aren't really in any URL. Some page may own the element which then owns the TabChildGlobal (in case of in-process). But I can change the ID to whatever feels the best :) I rarely use about:memory/compartment so I'm not really familiar with conventions there.
Comment 4•10 years ago
|
||
So the current patch gives us compartment([System Principal], inProcessTabChildGlobal?ownedby=...) ?
Assignee | ||
Comment 5•10 years ago
|
||
Yes [System Principal], inProcessTabChildGlobal?ownedBy=chrome://browser/content/browser.xul [3]
![]() |
||
Comment 6•10 years ago
|
||
More specific naming of compartments is always good... What name would these compartments have had before? How likely is the case where there isn't an "ownedBy" part?
Assignee | ||
Comment 7•10 years ago
|
||
Before the patch out-of-process tabchildglobals are just [System Principal] and in-process tabchildglobals are [System Principal|, chrome://browser/content/browser.xul which less-nicely mixes them with other system compartments. I mean, the top level chrome doc has chrome://browser/content/browser.xul as document uri, and the same is used for tabchildglobals, so they all are reported to be similar things.
![]() |
||
Updated•10 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P2]
![]() |
||
Comment 8•10 years ago
|
||
> [System Principal], inProcessTabChildGlobal?ownedBy=chrome://browser/content/browser.xul [3]
It's a bit ugly but I can't think of anything obviously better. Go for it.
Updated•10 years ago
|
Attachment #715642 -
Flags: review?(justin.lebar+bug) → review+
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c4498f0fd07
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7c4498f0fd07
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
![]() |
||
Comment 11•10 years ago
|
||
This change just led to bug 842710 being filed -- another case of "if we measure it, we find problems with it". Nice work.
Assignee | ||
Comment 12•10 years ago
|
||
You mean bug 844661
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•