make -vs- pymake: a few issues

RESOLVED WONTFIX

Status

Firefox Build System
General
RESOLVED WONTFIX
5 years ago
4 months ago

People

(Reporter: joey, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Checkout a clean copy of mozilla-central and run the check/unit test beneath config/makefiles/test and a few differences between make/pymake will show up.


% pwd
mozilla-central/obj-i686-pc-linux-gnu/config/makefiles/test

  o "make check" succeeds
  o "make.py check" fails.

  o A few different files are included by this unit test.  Source filename is not displayed by $(error)$(warning)$(info) so error messages have morphed into a generic "it failed" w/o context.

Expansion of variables 'errorifneq':1:0:1:50:expected [1] but found [0]

  o gmake command supports --debug[=FLAGS].  Passing this flag to pymake to add debug context will exhibit variant behavior.  The check test now succeeds w/o any content change:
    % make.py clean
    % make.py --debug check

pymake --help does not show --debug= as a valid option.  If the option is supported { make.py --debug did not error out } it will need to be documented along with tracking down the variant behavior source: make.py check failing while make.py --debug check succeeds.

  o Lastly, config/makefiles/test is listed in allmakefiles.sh.  The unit tests have deps on config/makefiles/*.mk and should run whenever files are edited.  If pymake reports an error locally when this unit test is run we should should see a similar failure for clobber builds or when autotargets.mk has been altered but do not remember seeing any reported.  Will submit a try job for windows to verify this is the case { unit test not being run }.



% /local/mozilla-central/build/pymake/make.py check
===================================================
make.py[0]: Entering directory '/local/mozilla-central/obj-i686-pc-linux-gnu/config/makefiles/test'
Expansion of variables 'errorifneq':1:0:1:50:expected [1] but found [0]
Mass close of pymake-related bugs.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.