Closed Bug 842741 Opened 10 years ago Closed 10 years ago

wrong release config bumped during Thunderbird 17.0.3

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

Details

Attachments

(1 file)

Related to bug 815302, we bumped comm-esr17's release config rather than comm-release's.
Since 17.0.3 and 17.0.3esr use the same branch,
http://hg.mozilla.org/build/tools/file/6efdaa82df4d/buildfarm/release/release-runner.py#l321 bumps the same files. The only difference coming from ship it is the name of release.

We can add a work around to detect "esr" and only then use esr config, but it sounds error prone.

We can also add another field to ship-it to override release config file (and forget to change it later :) ).

Or we can use comm-release repo for releases. :)
> We can add a work around to detect "esr" and only then use esr config, but
> it sounds error prone.

I don't think this would work....esr already works fine. It's non-esr releases building from esr that have issues.

(In reply to Rail Aliiev [:rail] from comment #1)
> We can also add another field to ship-it to override release config file
> (and forget to change it later :) ).

I don't think this is a good idea. It would let you do really dumb things (like use mozilla-beta release configs for a final release) that I don't know how to guard against.
Attached patch horrible hackSplinter Review
I wracked my brain trying to find a better fix for this, but the simple fact is that our in the rapid release world, our release automation assumes a 1:1 relationship between branches and releases. I wish we'd remembered this before implementing the Thunderbird-releases-out-of-esr17 :(.

We should take some time to think about whether or not this is a scenario that's worthwhile to support in the long term. If it is, we should make some higher level changes to the automation (like not putting branch names in config file names).

In the meantime, this should get us back into a working state, and also pain me greatly.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #717181 - Flags: review?(rail)
Comment on attachment 717181 [details] [diff] [review]
horrible hack

This exactly what I thought :)
For esr24 we shouldn't use the same repo
Attachment #717181 - Flags: review?(rail) → review+
Attachment #717181 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.