Closed Bug 842780 Opened 7 years ago Closed 7 years ago

about:newaddon doesn't restrict size of the add-on's icon

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: Unfocused, Assigned: sachin)

Details

Attachments

(2 files, 1 obsolete file)

Attached image Screenshot
Seems about:newaddon doesn't restrict the size of the add-on's icon, and blindly assumes the image is the right size. So if the add-on supplies a huge image for it's icon, it is shown at that huge size. See the attached screenshot for an example.
I would like to take this bug up.
So, what exactly is the right size for an addon's icon?
Flags: needinfo?(bmcbride)
It doesn't check the present size however, since I don't know what is a right size.
Please tell me if this is what I should be doing.
Attachment #738606 - Flags: feedback?(bmcbride)
Comment on attachment 738606 [details] [diff] [review]
Sets the image's width to 64px and height to 'auto'

Review of attachment 738606 [details] [diff] [review]:
-----------------------------------------------------------------

We support 32x32 and 64x64 sized icons for this. The way other code handles this is to set max-width:64px; max-height:64px; in the CSS file - that way the image will automatically show as its original size (without scaling) if it's not too big, or be scaled down to 64x64 if it's too big.
Attachment #738606 - Flags: feedback?(bmcbride) → feedback-
Flags: needinfo?(bmcbride)
(Btw, thanks for picking up all these bugs. Sorry for any delays in replying - I've been off sick.)
Assignee: nobody → sachinhosmani2
Status: NEW → ASSIGNED
Attachment #738606 - Attachment is obsolete: true
Attachment #740674 - Flags: review?(bmcbride)
(In reply to Blair McBride [:Unfocused] (Back from the dead. Mostly.) from comment #4)
> (Btw, thanks for picking up all these bugs. Sorry for any delays in replying
> - I've been off sick.)

No problem. Thank you :)
Attachment #740674 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/mozilla-central/rev/6b6e79e65b37
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.