842780 - about:newaddon doesn't restrict size of the add-on's icon

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot

Seems about:newaddon doesn't restrict the size of the add-on's icon, and blindly assumes the image is the right size. So if the add-on supplies a huge image for it's icon, it is shown at that huge size. See the attached screenshot for an example.

Comment 1

[Sachin Hosmani [:sachin]]

I would like to take this bug up.
So, what exactly is the right size for an addon's icon?

Comment 2

[Sachin Hosmani [:sachin]]

Attachment: Sets the image's width to 64px and height to 'auto'

It doesn't check the present size however, since I don't know what is a right size.
Please tell me if this is what I should be doing.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 738606 [details] [diff] [review]
Sets the image's width to 64px and height to 'auto'

Review of attachment 738606 [details] [diff] [review]:
-----------------------------------------------------------------

We support 32x32 and 64x64 sized icons for this. The way other code handles this is to set max-width:64px; max-height:64px; in the CSS file - that way the image will automatically show as its original size (without scaling) if it's not too big, or be scaled down to 64x64 if it's too big.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(Btw, thanks for picking up all these bugs. Sorry for any delays in replying - I've been off sick.)

Comment 5

[Sachin Hosmani [:sachin]]

Attachment: Sets the max-height and max-weight CSS properties.

Comment 6

[Sachin Hosmani [:sachin]]

(In reply to Blair McBride [:Unfocused] (Back from the dead. Mostly.) from comment #4)
> (Btw, thanks for picking up all these bugs. Sorry for any delays in replying
> - I've been off sick.)

No problem. Thank you :)

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/6b6e79e65b37

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6b6e79e65b37