Closed
Bug 842780
Opened 7 years ago
Closed 7 years ago
about:newaddon doesn't restrict size of the add-on's icon
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Not set
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: Unfocused, Assigned: sachin)
Details
Attachments
(2 files, 1 obsolete file)
232.33 KB,
image/png
|
Details | |
3.22 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
Seems about:newaddon doesn't restrict the size of the add-on's icon, and blindly assumes the image is the right size. So if the add-on supplies a huge image for it's icon, it is shown at that huge size. See the attached screenshot for an example.
Assignee | ||
Comment 1•7 years ago
|
||
I would like to take this bug up. So, what exactly is the right size for an addon's icon?
Flags: needinfo?(bmcbride)
Assignee | ||
Comment 2•7 years ago
|
||
It doesn't check the present size however, since I don't know what is a right size. Please tell me if this is what I should be doing.
Attachment #738606 -
Flags: feedback?(bmcbride)
Reporter | ||
Comment 3•7 years ago
|
||
Comment on attachment 738606 [details] [diff] [review] Sets the image's width to 64px and height to 'auto' Review of attachment 738606 [details] [diff] [review]: ----------------------------------------------------------------- We support 32x32 and 64x64 sized icons for this. The way other code handles this is to set max-width:64px; max-height:64px; in the CSS file - that way the image will automatically show as its original size (without scaling) if it's not too big, or be scaled down to 64x64 if it's too big.
Attachment #738606 -
Flags: feedback?(bmcbride) → feedback-
Flags: needinfo?(bmcbride)
Reporter | ||
Comment 4•7 years ago
|
||
(Btw, thanks for picking up all these bugs. Sorry for any delays in replying - I've been off sick.)
Assignee: nobody → sachinhosmani2
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #738606 -
Attachment is obsolete: true
Attachment #740674 -
Flags: review?(bmcbride)
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Blair McBride [:Unfocused] (Back from the dead. Mostly.) from comment #4) > (Btw, thanks for picking up all these bugs. Sorry for any delays in replying > - I've been off sick.) No problem. Thank you :)
Reporter | ||
Updated•7 years ago
|
Attachment #740674 -
Flags: review?(bmcbride) → review+
Reporter | ||
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6b6e79e65b37
Flags: in-testsuite-
Comment 8•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6b6e79e65b37
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•