Closed Bug 842805 Opened 7 years ago Closed 7 years ago

Use of API deprecated in Qt5

Categories

(Core Graveyard :: Widget: Qt, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: tatiana, Assigned: tatiana)

Details

Attachments

(1 file, 2 obsolete files)

Assignee: nobody → tanya.meshkova
Attached patch patch (obsolete) — Splinter Review
Attachment #715779 - Flags: review?(romaxa)
Comment on attachment 715779 [details] [diff] [review]
patch

Please also change 
http://mxr.mozilla.org/mozilla-central/source/configure.in#4665

PKG_CHECK_MODULES(MOZ_QT5, QtWidgets QtMultimedia QtPrintSupport,
to Qt5Widgets Qt5Multimedia...
Attached patch patch v2 (obsolete) — Splinter Review
Attachment #715779 - Attachment is obsolete: true
Attachment #715779 - Flags: review?(romaxa)
Attachment #716352 - Flags: review?(romaxa)
Comment on attachment 716352 [details] [diff] [review]
patch v2

Mike could you double check configure part.
Attachment #716352 - Flags: review?(romaxa)
Attachment #716352 - Flags: review?(mh+mozilla)
Attachment #716352 - Flags: review+
Comment on attachment 716352 [details] [diff] [review]
patch v2

Review of attachment 716352 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +4697,5 @@
> +            MOZ_QT_CFLAGS="$MOZ_QT_CFLAGS -I$QTDIR/include/QtGui"
> +            MOZ_QT_CFLAGS="$MOZ_QT_CFLAGS -I$QTDIR/include/QtCore"
> +            MOZ_QT_CFLAGS="$MOZ_QT_CFLAGS -I$QTDIR/include/QtNetwork"
> +            MOZ_QT_CFLAGS="$MOZ_QT_CFLAGS -I$QTDIR/include/QtXml"
> +            MOZ_QT_CFLAGS="$MOZ_QT_CFLAGS -I$QTDIR/include/QtDeclarative"

Can't you set these commonly, avoiding the duplication?
Attachment #716352 - Flags: review?(mh+mozilla) → review+
moving r+ from previous patch
Attachment #716352 - Attachment is obsolete: true
Attachment #718059 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f826daae4e65
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.