842831 - Allow reviewers to search by privileged packaged apps

Status: VERIFIED FIXED

(Marketplace Graveyard :: Search, defect, P2)

Description

[Rob Hudson [:robhudson]]

We don't currently have a field for this in our index or track it in the database. But if we stored the "type" field of the manifest we could easily filter by this.

Comment 1

[Andrew Williamson [:eviljeff]]

Aware its a different bug, but indicating if the app is privileged with an icon in the queue and on the review page is much more important than being able to search for it, imo.

Comment 2

[Mathieu Pillard [:mat]]

The icon was added to the queue page but we need to do this again for the search results. It should just be a matter of adding something like flags.push({suffix: 'packaged-app', title: gettext('Privileged App')}); in mkt/reviewers.js:buildAppResultRow() - I couldn't do this in bug 846420 because we didn't have latest_version in our index at the moment. See also bug 848446

Comment 3

[Mathieu Pillard [:mat]]

This was fixed in https://github.com/mozilla/zamboni/commit/0d71a0cc9d221616d282f00295eae281a72664dd

But: it doesn't fully work, there was a fix that is part of bug 848446 (which will be fixed soon) that we need to make everything work correctly.

Comment 4

[Mathieu Pillard [:mat]]

848446 is now fixed so this should work.

Steps to reproduce:
- Find/upload a privileged packaged app on -dev.
- Load the reviewers tools advanced search
- Find your app using the new "Privileged App" field. Also test that "Unknown" doesn't apply the filter and that "No" works as a filter value as well.

Comment 5

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/reviewers/apps/queue/ on FF25 (Win 7).
Postfix screencast http://screencast.com/t/4ZggbSeh
Closing bug.