Closed Bug 842839 Opened 7 years ago Closed 7 years ago

Some add-on SDK files use windows line endings

Categories

(Add-on SDK Graveyard :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(2 files)

We aim to keep m-c clean of windows line endings so this will correct some that have crept in.
Comment on attachment 715776 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/807

Corrected the line endings in 4 files. Left the .bat files with windows line endings.
Attachment #715776 - Flags: review?(zer0)
Attachment #715778 - Flags: review?(gps)
Comment on attachment 715778 [details] [diff] [review]
correct files in m-c

Review of attachment 715778 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #715778 - Flags: review?(gps) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/18fa6e840300

The SDK files will get landed in github and uplifted next week.
Whiteboard: [leave open]
Priority: -- → P1
Attachment #715776 - Flags: review?(zer0) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/8d638e71c13910401d5b783cc3bdc0b2852228e7
Bug 842839: Some add-on SDK files use windows line endings.

https://github.com/mozilla/addon-sdk/commit/2bee189e1cb87f5fbe38ce862c8ff35ee0978480
Merge pull request #807 from Mossop/bug842839

Bug 842839: Some add-on SDK files use windows line endings. r=gozala
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
You need to log in before you can comment on or make changes to this bug.