842889 - update JS_GetImplentationVersion()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[darkxst]

This function returns a hardcoded string that has not changed in years, it is probably not that useful and once the new standalone spidermonkey versioning lands, then its likely to just cause confuse.

The only thing that uses this is the js shell, I can't find any projects (on linux atleast) that use this, some suggested on IRC that we should just remove it. Perhaps with an arbitrary version bump for esr17 release.

If this seems like the right way to go, I will prepare some patches.

Comment 1

[Jeff Walden [:Waldo]]

As I said on IRC:

<Waldo> I like removing that, but is it really necessary to do that now? or to try to push it into an already-late esr17 release? do it on trunk, totally separate from all the packaging stuff and timelines, and let it make its way into a release in due time
<Waldo> I'm not going to argue strongly against doing it, because I don't care that much, but this seems unnecessary now

So in my view, fine to make the change on trunk at any time, no good reason it must be done immediately, or before an esr17-based release.  Indeed we shouldn't spend any time on it *until* that release happens, I think.

Comment 2

[darkxst]

Attachment: use MOZILLA_VERSION for JS_GetImplementationVersion

Comment 3

[Sean Stangl [:sstangl]]

Comment on attachment 715846 [details] [diff] [review]
use MOZILLA_VERSION for JS_GetImplementationVersion

IT IS TIME.

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 715846 [details] [diff] [review]
use MOZILLA_VERSION for JS_GetImplementationVersion

Review of attachment 715846 [details] [diff] [review]:
-----------------------------------------------------------------

Fine enough.  But note this bug was filed to remove it entirely, see comment 0.  :-)  r=me on this or that, but it sounds like this function just isn't that useful, so we might as well just remove it entirely from JSAPI.

Comment 5

[Sean Stangl [:sstangl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b51eaa301a4a

Changed returned string rather than modifying public API. The call does seem useless and can probably be removed, but I'm hesitant to touch the interface, even for useless functions.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b51eaa301a4a