Closed Bug 842897 Opened 11 years ago Closed 11 years ago

Intermittent testDistribution | GeckoEventExpecter - blockForEvent timeout: Distribution:Set:OK

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME
Milestone:
Firefox 22

People

(Reporter: philor, Assigned: Margaret)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

patch
3.52 KB, patch
gbrown
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=19892901&tree=Mozilla-Inbound
Android Armv6 Tegra 250 mozilla-inbound opt test robocop on 2013-02-19 16:07:24 PST for push d7a598707128
slave: tegra-165

2 INFO TEST-UNEXPECTED-FAIL | testDistribution | GeckoEventExpecter - blockForEvent timeout: Distribution:Set:OK
02-19 17:01:48.254 I/Robocop (10274): 2 INFO TEST-UNEXPECTED-FAIL | testDistribution | GeckoEventExpecter - blockForEvent timeout: Distribution:Set:OK
02-19 17:01:48.264 I/TestRunner(10274): junit.framework.AssertionFailedError: 2 INFO TEST-UNEXPECTED-FAIL | testDistribution | GeckoEventExpecter - blockForEvent timeout: Distribution:Set:OK
02-19 17:01:48.254 I/Robocop (10274): 2 INFO TEST-UNEXPECTED-FAIL | testDistribution | GeckoEventExpecter - blockForEvent timeout: Distribution:Set:OK
02-19 17:01:48.264 I/TestRunner(10274): junit.framework.AssertionFailedError: 2 INFO TEST-UNEXPECTED-FAIL | testDistribution | GeckoEventExpecter - blockForEvent timeout: Distribution:Set:OK
I have a vague concern about using blockForEvent in setUp...this may be the only test that uses event expecters so early.
I decided to do that because I was planning on trying to use the ContentProviderTest setUp method to set up BrowserProvider after the distribution was set up. However, I'm not doing that right now, so there's no reason for the blockEvent in setUp.

I can make a patch to move this around and we can see if that fixes things.
Assignee: nobody → margaret.leibovic
Pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=bac572edd4dc

If this passes, maybe we can trigger more test runs to see if this makes us feel confident about this fix.
Attached patch patch — — Splinter Review 
The try run was green, but I triggered a few more runs of the robocop tests on Armv6, since that's what failed.
Attachment #716252 - Flags: review?(gbrown)
Comment on attachment 716252 [details] [diff] [review]
patch

Review of attachment 716252 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: mobile/android/base/tests/testDistribution.java.in
@@ +58,5 @@
> +            Actions.EventExpecter distributionSetExpecter = mActions.expectGeckoEvent("Distribution:Set:OK");
> +            init.invoke(null, mActivity, getMockPackagePath());
> +            distributionSetExpecter.blockForEvent();
> +        } catch (Exception e) {
> +            mAsserter.ok(false, "exception initialzing distribution", e.toString());

s/initialzing/initializing/
Attachment #716252 - Flags: review?(gbrown) → review+
https://hg.mozilla.org/mozilla-central/rev/e677416996aa
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Er, looks like that fix didn't work :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This hasn't happened in over a month... what's our policy on closing out intermittent oranges?
Resolving as WORKSFORME, since this appears to have gone away.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → WORKSFORME
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: