842924 - Localization issue with reset period control

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P2)

Description

[Francesco Lodolo [:flod]]

Attachment: Reset period control is too narrow

English strings: Monthly, Weekly, Never.
Italian strings: Ogni mese, Ogni settimana, Mai.

Even if I choose to use adverbs it doesn't get shorter (Mensilmente, Settimanalmente).

With the current layout I don't think this is localizable in many languages.

Comment 1

[Francesco Lodolo [:flod]]

Problem is still present (Unagi, build 2013-06-25).

Comment 2

[Alex Keybl [:akeybl]]

Italian is not a v1.1 language according to internal docs - are you aware of other impacted languages?

Comment 3

[Francesco Lodolo [:flod]]

Some examples that I doubt fit in this design (es, pt-BR, de seem to have shorter strings this time, I wonder if they had to compromise for it)

pl
monthly = Co miesiąc
weekly = Co tydzień

el
monthly = Μηνιαία
weekly = Εβδομαδιαία

nl
monthly = Maandelijks
weekly = Wekelijks

ru
monthly = Ежемесячно
weekly = Еженедельно

Comment 4

[Francesco Lodolo [:flod]]

Attachment: Polish screenshot

Polish screenshot.

Other languages (e.g. pt-BR) has issues with the name of the day (not sure why Polish is using numbers here).

Comment 5

[Francesco Lodolo [:flod]]

Requesting again blocking->leo?

Comment 6

[Staś Małolepszy :stas]

(In reply to Francesco Lodolo [:flod] from comment #4)

> Other languages (e.g. pt-BR) has issues with the name of the day (not sure
> why Polish is using numbers here).

It's because in the screenshot, the "monthly" options is selected.  If you select "weeky", the names of days don't fit either.

Comment 7

[Dietrich Ayala (:dietrich)]

leo+ for fixing for launch languages.

Comment 8

[Jakub Siemiatkowski (:sasklacz)]

So what is the desired way of fixing this. Broader select field ?

Comment 9

[Francesco Lodolo [:flod]]

I guess that's up to the UX team, but for me the only safe way out of this is to have one line for the label and another one for the listbox (we have space below).

Comment 10

[Salvador de la Puente González [:salva]]

(In reply to Francesco Lodolo [:flod] from comment #9)
> I guess that's up to the UX team, but for me the only safe way out of this
> is to have one line for the label and another one for the listbox (we have
> space below).

Sounds nice to me. Trying to sync with UX to achieve the best result for this strategy.

Comment 11

[Sergi]

Hi guys,

we had a similar problem in the clock app when setting up the alarms, so we decided to do a small update to these buttons. Basically we should not be using the small buttons aligned to the right. The problem, as you've been suffering, is that it's really difficult to fit any value within a button that small, so we decided to go with a regular button containing the value with a label on top of it.

You can check the visuals through this link: https://bug867038.bugzilla.mozilla.org/attachment.cgi?id=750660

Thanks!

Comment 12

[chris hofmann]

when is the patch expected to land for this?

Comment 13

[Salvador de la Puente González [:salva]]

(In reply to Sergi from comment #11)
> Hi guys,
> 
> we had a similar problem in the clock app when setting up the alarms, so we
> decided to do a small update to these buttons. Basically we should not be
> using the small buttons aligned to the right. The problem, as you've been
> suffering, is that it's really difficult to fit any value within a button
> that small, so we decided to go with a regular button containing the value
> with a label on top of it.
> 
> You can check the visuals through this link:
> https://bug867038.bugzilla.mozilla.org/attachment.cgi?id=750660
> 
> Thanks!

Thank you very much Sergi!

(In reply to chris hofmann from comment #12)
> when is the patch expected to land for this?

This weekend.

Comment 14

[Salvador de la Puente González [:salva]]

Attachment: Avoid l10n issues by providing wider selects

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 771977 [details]
Avoid l10n issues by providing wider selects

Simple and non risky change,

Thanks Salva!

Comment 16

[Salvador de la Puente González [:salva]]

Master: 89d2ec965d3c7422359ca383b40c26a738610ba3

Comment 17

[Delphine Lebédel [:delphine - Use needinfo]]

Is this going to land on v1 train as well?

Comment 18

[Salvador de la Puente González [:salva]]

It should, it is leo+

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 89d2ec965d3c7422359ca383b40c26a738610ba3 to:
v1-train: 322435efe0e69bc0b19982f6cc4e02964426cff3

Comment 20

[dkumar]

Can you please provide steps to verify this fix.

Comment 21

[dkumar]

Verified, fixed on leo Moz RIL
Environmental Variables
Build ID: 20130723070209
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: ffe25bfdf0e71c820ca710cb61fb8306564a8f4e
Platform Version: 18.1

Issue does not reproduce reset period control is not too narrow and fits all the string into the textbox ... please ignore comment 20

Comment 22

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 322435efe0e69bc0b19982f6cc4e02964426cff3