843020 - start -> run file names with spaces don't load properly

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Shell, defect)

Description

[Jim Mathies [:jimm]]

STR:

1) set fx as the default desktop browser
2) create an html file on the desktop named '1 2 3.html'
3) start -> browse for the file and open

result:

desktop browser launches and we get three tabs. one with 
file:///C:/Users/(user)/Desktop/1
file:///C:/Users/(user)/Desktop/2
www.3.html

I'll post ceh output here in a sec, but that part looks ok.

Comment 1

[Jim Mathies [:jimm]]

SetParameters: ''
SetSelection param count: 1
SetSelection param: 'C:\Users\jim\Desktop\1 0 3.html'
No data object or data object has no text.
SetSelection target: C:\Users\jim\Desktop\1 0 3.html
Initialize(open)
IExecuteCommandApplicationHostEnvironment::GetValue()
GetUIMode: 0
QueryAppIsDefaultAll: 1
QueryCurrentDefault: 0
registeredApp=FirefoxURL
returning AHE_DESKTOP
Execute()
Desktop Launch: verb:open exe:T:\Mozilla\MC-REL\dist\bin\firefox.exe params:-url C:\Users\jim\Desktop\1 0 3.html

Comment 2

[Jim Mathies [:jimm]]

Actually, maybe we just need to quote that url param in the ceh to fix this.

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch

yep, that fixes it.

Comment 4

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4780b6fe2826

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4780b6fe2826