843066 - [SMS] Callback in 'appendThreads' & 'renderMessages' is not working properly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 2

[Borja Salguero [:borjasalguero]]

Currently we are not handling the callback properly! Right now the callback is not called when the rendering it's done, so it could produce weird behaviours & errors. We need to fix it in order to ensure that the callback is called when it should be called.

This is blocking the SMS Tests due to the callback was not called in the right moment.

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 716045 [details]
Pull Request

r=me with the changes asked on the PR

please do all the changes before pushing and then put the commit URL (both the original commit and the merge commit) in a comment here :)

Comment 4

[Borja Salguero [:borjasalguero]]

Merged!

https://github.com/borjasalguero/gaia/commit/e045526ea102664e9374b133e1b94161016bac5f
https://github.com/mozilla-b2g/gaia/commit/c59c3be24831b51114ee194a8555343dd826c857

Comment 5

[Borja Salguero [:borjasalguero]]

Comment on attachment 716045 [details]
Pull Request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Changes in rendering
User impact if declined: Callback (function called after rendering the whole list of threads/messages) is not executed properly! So we could have weird behaviours & errors. Furthermore this change it's needed in order to restore the Tests.
Testing completed: 
Risk to taking this patch (and alternatives if risky): Low. But It's needed in order to restore the patch so it's a 'must to have' !
String or UUID changes made by this patch:

Comment 6

[Maria Angeles Oteo (:oteo)]

It's necessary that this patch lands in v1-train and v1.0.1 because this bug was due to a regression in bug 833010 that landed in v1.0.1.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

If this needs to fix the regression that landed on v1.0.1 then we'll block here so this can be uplifted to v1.0.1

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train@8bff6101ca7d2378bd3e54994a7c1acd459f9ee4
v1.0.1@c4b6e04721d7381bcc52326a8c2d6cf42e3e5347

Comment 9

[Cody Roesch [:croesch]]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 10

[Borja Salguero [:borjasalguero]]

There is no checking here, only that the App is working as expected.