"Harlem Shake" performance can be improved

RESOLVED INCOMPLETE

Status

()

RESOLVED INCOMPLETE
6 years ago
3 years ago

People

(Reporter: krystian4842, Unassigned)

Tracking

({perf})

Trunk
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130212082553

Steps to reproduce:

Go to this address:
http://hsmaker.com/harlemshake.asp?url=http://bbc.co.uk



Expected results:

Improvements would be welcome - performance-wise and processor-wise (mine is at 50%).
(Reporter)

Updated

6 years ago
SPS-Profile against Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130224 Firefox/22.0 ID:20130224031053 CSet: 195e706140d1: 

http://people.mozilla.com/~bgirard/cleopatra/#report=46ad7671424b7903edf002ce7bdac010fd76a748

Selection - Most time spent in:

SelectorMatchesTree
SelectorMatchesTree
RuleHash::EnumerateAllRules(mozilla::dom::Element *,ElementDependentRuleProcessorData *,NodeMatchContext &)
EnumRulesMatching<ElementRuleProcessorData>
nsStyleSet::FileRules(bool (*)(nsIStyleRuleProcessor *,void *),RuleProcessorData *,mozilla::dom::Element *,nsRuleWalker *)
nsStyleSet::FileRules
nsStyleSet::ResolveStyleFor(mozilla::dom::Element *,nsStyleContext *,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ReResolveStyleContext(nsPresContext *,nsIFrame *,nsIContent *,nsStyleChangeList *,nsChangeHint,nsChangeHint,nsRestyleHint,mozilla::css::RestyleTracker &,nsFrameManager::DesiredA11yNotifications,nsTArray<nsIContent *> &,TreeMatchContext &)
nsFrameManager::ComputeStyleChangeFor(nsIFrame *,nsStyleChangeList *,nsChangeHint,mozilla::css::RestyleTracker &,bool)
CSS::ComputeStyleChangeFor
nsCSSFrameConstructor::RestyleElement(mozilla::dom::Element *,nsIFrame *,nsChangeHint,mozilla::css::RestyleTracker &,bool)
mozilla::css::RestyleTracker::DoProcessRestyles()
CSS::ProcessRestyles
Component: Untriaged → Style System (CSS)
Keywords: perf
Product: Firefox → Core
Version: 19 Branch → Trunk
This is mostly about doing off-mainthread animations on desktop, no?  At least as far as I can tell...
(Reporter)

Comment 3

5 years ago
Animations are still choppy in trunk whereas it's smooth in the latest stable version of Chrome.

Comment 4

3 years ago
The link is not working anymore, so nothing else to test here. And OMTA landed a few months ago.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.