Add number/list of folders chosen in the saved search (virtual folder) creation/edit dialog

RESOLVED FIXED in Thunderbird 42.0

Status

defect
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({ux-userfeedback})

Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.40 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

10.43 KB, patch
rkent
: review+
bwinton
: ui-review+
Details | Diff | Splinter Review
1.34 KB, patch
philip.chee
: review+
Details | Diff | Splinter Review
The virtual folder creation/edit dialog does not show if any folders are already chosen so it looks a bit empty and the user may not be sure his selection was accepted.

While there, fix the style of the folder picker (of the folder to save to).
Posted patch WIP patch (obsolete) — Splinter Review
Something like this. It is to decide if the count of folders is enough, or we try to show some names of the folders with ellipsis if not fitting.
Attachment #716207 - Flags: feedback?(bwinton)
Although I think that this patch is a net gain, would it be better to automatically expand folders that have marked children? Or perhaps use some alternate styling of parents with marked children?
(In reply to :aceman from comment #1)
> WIP patch

I prefer folder pane like pane at left for current selection, with excluding/hiding account/folder name if no sub folder is selected, with automatic expansion and with unselected-parent-folder grayed out(\Noselect folder like) if subfolder is selected.
I'm too greedy? :-)
I am not sure how the 2 comments relate to this bug. Are you guys talking about expanding/styling of the list that appears after clicking the Choose button?
No, I simply wanted big enhancement of "simple list of selected folders" => "tree style display of currently selected folders at new left pane which is not changeable, to which selection change result via Choose button is automatically reflected after end of selection by user".
Ok, then please create a new bug for that because that is out of the scope of this bug. That list of folders is created via RDF and I am not able to touch that. I think we want to remove that RDF stuff so a new bug is needed anyway (if it does not already).
Could we do something like a count of folders, with a tooltip (and/or a (+) button) that shows the whole list?  (Otherwise, I agree with rkent.  It seems like a net gain.)
Attachment #716207 - Flags: feedback?(bwinton) → feedback+
Yes, the tooltip should be doable.
Any opinions on the positioning of the count and the accompanying string ("folders chosen" so far)? Also what about the format of the folder names? Just folder name or the "folder on server" style?
Flags: needinfo?(bwinton)
The positioning seems fine.
The text should be pluralized correctly, with no ":" after. (i.e. "1 folder chosen").
I think just folder name, unless there is more than one folder with that name.
  In that case, "folder on server", or whatever else makes the name unique.
  (I believe we already have logic to do that for us, although I could be wrong.)
Flags: needinfo?(bwinton)
We have similar logic for this in the folder picker -> Recent menu.
Maybe we could reuse it somehow.
But I am not sure it is worth it, as you can just click Choose, if you want to see the list of folders.
Posted patch patch v2Splinter Review
For somebody with 1000 folders, it may be easier to see the new tooltip and check the 5 selected folders for correctness, than verifying in the full list. So let's try this again.
Attachment #716207 - Attachment is obsolete: true
Attachment #8606670 - Flags: ui-review?(bwinton)
Comment on attachment 8606670 [details] [diff] [review]
patch v2

Yeah, seems good.
Attachment #8606670 - Flags: ui-review?(bwinton) → ui-review+
Attachment #8606670 - Flags: review?(rkent)
Comment on attachment 8606670 [details] [diff] [review]
patch v2

Review of attachment 8606670 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8606670 - Flags: review?(rkent) → review+
Thanks.
Keywords: checkin-needed
url:        https://hg.mozilla.org/comm-central/rev/415fa4ec053586f45c9236295aa764c915ad92ae
changeset:  415fa4ec053586f45c9236295aa764c915ad92ae
user:       aceman <acelists@atlas.sk>
date:       Sat May 16 11:37:00 2015 +0200
description:
Bug 843320 - Add number and list of folders chosen in the saved search (virtual folder) creation/edit dialog. ui-r=bwinton, r=rkent
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 42.0
> mail/locales/en-US/chrome/messenger/messenger.properties
What about SeaMonkey's messenger.properties ?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Sorry, must have got lost in the translation :)

Is Seamonkey totally broken at startup, or only if one opens the dialog?
Attachment #8645384 - Flags: review?(philip.chee)
Comment on attachment 8645384 [details] [diff] [review]
string for Seamonkey

Muchos gracias

(In reply to :aceman from comment #18)
> Is Seamonkey totally broken at startup, or only if one opens the dialog?
Only when you open the dialog
Attachment #8645384 - Flags: review?(philip.chee) → review+
http://hg.mozilla.org/comm-central/rev/18dc81215fb9
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Depends on: 1226048
You need to log in before you can comment on or make changes to this bug.