Add number/list of folders chosen in the saved search (virtual folder) creation/edit dialog

RESOLVED FIXED in Thunderbird 42.0

Status

MailNews Core
Search
RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({ux-userfeedback})

Trunk
Thunderbird 42.0
ux-userfeedback

SeaMonkey Tracking Flags

(seamonkey2.40 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

10.43 KB, patch
rkent
: review+
bwinton
: ui-review+
Details | Diff | Splinter Review
1.34 KB, patch
Philip Chee
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
The virtual folder creation/edit dialog does not show if any folders are already chosen so it looks a bit empty and the user may not be sure his selection was accepted.

While there, fix the style of the folder picker (of the folder to save to).
(Assignee)

Comment 1

4 years ago
Created attachment 716207 [details] [diff] [review]
WIP patch

Something like this. It is to decide if the count of folders is enough, or we try to show some names of the folders with ellipsis if not fitting.
Attachment #716207 - Flags: feedback?(bwinton)

Comment 2

4 years ago
Although I think that this patch is a net gain, would it be better to automatically expand folders that have marked children? Or perhaps use some alternate styling of parents with marked children?
(In reply to :aceman from comment #1)
> WIP patch

I prefer folder pane like pane at left for current selection, with excluding/hiding account/folder name if no sub folder is selected, with automatic expansion and with unselected-parent-folder grayed out(\Noselect folder like) if subfolder is selected.
I'm too greedy? :-)
(Assignee)

Comment 4

4 years ago
I am not sure how the 2 comments relate to this bug. Are you guys talking about expanding/styling of the list that appears after clicking the Choose button?
No, I simply wanted big enhancement of "simple list of selected folders" => "tree style display of currently selected folders at new left pane which is not changeable, to which selection change result via Choose button is automatically reflected after end of selection by user".
(Assignee)

Comment 6

4 years ago
Ok, then please create a new bug for that because that is out of the scope of this bug. That list of folders is created via RDF and I am not able to touch that. I think we want to remove that RDF stuff so a new bug is needed anyway (if it does not already).
Could we do something like a count of folders, with a tooltip (and/or a (+) button) that shows the whole list?  (Otherwise, I agree with rkent.  It seems like a net gain.)
Attachment #716207 - Flags: feedback?(bwinton) → feedback+
(Assignee)

Comment 8

4 years ago
Yes, the tooltip should be doable.
Any opinions on the positioning of the count and the accompanying string ("folders chosen" so far)? Also what about the format of the folder names? Just folder name or the "folder on server" style?
Flags: needinfo?(bwinton)
The positioning seems fine.
The text should be pluralized correctly, with no ":" after. (i.e. "1 folder chosen").
I think just folder name, unless there is more than one folder with that name.
  In that case, "folder on server", or whatever else makes the name unique.
  (I believe we already have logic to do that for us, although I could be wrong.)
Flags: needinfo?(bwinton)
(Assignee)

Comment 10

4 years ago
We have similar logic for this in the folder picker -> Recent menu.
Maybe we could reuse it somehow.
(Assignee)

Comment 11

4 years ago
But I am not sure it is worth it, as you can just click Choose, if you want to see the list of folders.
(Assignee)

Comment 12

2 years ago
Created attachment 8606670 [details] [diff] [review]
patch v2

For somebody with 1000 folders, it may be easier to see the new tooltip and check the 5 selected folders for correctness, than verifying in the full list. So let's try this again.
Attachment #716207 - Attachment is obsolete: true
Attachment #8606670 - Flags: ui-review?(bwinton)
Comment on attachment 8606670 [details] [diff] [review]
patch v2

Yeah, seems good.
Attachment #8606670 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

2 years ago
Attachment #8606670 - Flags: review?(rkent)

Comment 14

2 years ago
Comment on attachment 8606670 [details] [diff] [review]
patch v2

Review of attachment 8606670 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8606670 - Flags: review?(rkent) → review+
(Assignee)

Comment 15

2 years ago
Thanks.
Keywords: checkin-needed

Comment 16

2 years ago
url:        https://hg.mozilla.org/comm-central/rev/415fa4ec053586f45c9236295aa764c915ad92ae
changeset:  415fa4ec053586f45c9236295aa764c915ad92ae
user:       aceman <acelists@atlas.sk>
date:       Sat May 16 11:37:00 2015 +0200
description:
Bug 843320 - Add number and list of folders chosen in the saved search (virtual folder) creation/edit dialog. ui-r=bwinton, r=rkent

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 42.0

Comment 17

2 years ago
> mail/locales/en-US/chrome/messenger/messenger.properties
What about SeaMonkey's messenger.properties ?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 18

2 years ago
Sorry, must have got lost in the translation :)

Is Seamonkey totally broken at startup, or only if one opens the dialog?
(Assignee)

Comment 19

2 years ago
Created attachment 8645384 [details] [diff] [review]
string for Seamonkey
Attachment #8645384 - Flags: review?(philip.chee)

Comment 20

2 years ago
Comment on attachment 8645384 [details] [diff] [review]
string for Seamonkey

Muchos gracias

(In reply to :aceman from comment #18)
> Is Seamonkey totally broken at startup, or only if one opens the dialog?
Only when you open the dialog
Attachment #8645384 - Flags: review?(philip.chee) → review+

Comment 21

2 years ago
http://hg.mozilla.org/comm-central/rev/18dc81215fb9
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
status-seamonkey2.40: --- → fixed
Resolution: --- → FIXED

Updated

a year ago
Depends on: 1226048
You need to log in before you can comment on or make changes to this bug.