Closed
Bug 843324
Opened 11 years ago
Closed 11 years ago
BaselineCompiler: Change Call_Scripted stub to guard on script instead of JSFunction.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: djvj, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
8.26 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Date-format-tofte hits this. This brings up the issue that if we switch the stub to storing the script, Ion can't figure out from the stub chain which actual scripted functions showed up at that location, but that's OK because Ion will have to guard against the actual callee at runtime anyway, and the actual callee function will be available at that point.
|
Reporter | |
Updated•11 years ago
|
Summary: BaselineCompiler: Change Call_Native stub to guard on script instead of JSFunction. → BaselineCompiler: Change Call_Scripted stub to guard on script instead of JSFunction.
|
|
Reporter | |
Comment 1•11 years ago
|
||
Talked to nbp about this, we should be able to make Ion work with it.
Attachment #716215 -
Flags: review?(jdemooij)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 716215 [details] [diff] [review] Change ICCall_Scripted to guard on JSScript instead of JSFunction Review of attachment 716215 [details] [diff] [review]: ----------------------------------------------------------------- Awesome.
Attachment #716215 -
Flags: review?(jdemooij) → review+
|
|
Reporter | |
Comment 3•11 years ago
|
||
Found a bug in the asmgen and fixed it before pushing: https://hg.mozilla.org/projects/ionmonkey/rev/98139e54ea66
|
|
Reporter | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•