843378 - DeviceManagerADB doesn't always raise an exception if it can't connect

Status: RESOLVED WONTFIX

(Testing :: Mozbase, defect)

Description

[Mark Côté [:mcote]]

From bug 842667:

If you instantiate a DeviceManagerADB object with the correct port, and then one without, you don't always get an error, although the device is indeed not found:

>>> dm = DeviceManagerADB(host='192.168.1.158', port=5555)
>>> dm = DeviceManagerADB(host='192.168.1.158', port=12345)
>>> dm.listFiles('/mnt')
['error: device not found']

Apparently this is a result of _disconnectRemoteADB() not being called first, since an exception is always raised if the DeviceManagerADB is deleted before being recreated--though this raises the question if two DeviceManagerADB objects can exist at the same time and work properly.

Comment 1

[William Lachance (:wlach)]

Part of me wonders if we shouldn't just disable this "adb over tcp" support for dmADB, and force the user to set that sort of thing up manually if that's what they want to do. There's a whole bunch of edge cases to doing this that are hard to get right. For example, what happens if the user set up a tcp connection with the device before the test?