843397 - Don't make users who are logged into mktplace log in to webpay

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Go to the details page for a paid app
2. Click on the purchase button
3. Sign in using Identity

expected behavior:
The purchase flow starts and user goes to the PIN screen

observed behavior:
The purchase flow starts and the user ends up in the "Sign in" screen for Webpay.

Comment 1

[Wraithan (Chris McDonald) [:wraithan]]

I remember Kumar saying this had to do with:

https://github.com/mozilla/webpay/blob/master/webpay/settings/base.py#L232

Perhaps he knows more about it.

Comment 2

[Kumar McMillan [:kumar]]

We need to fix this. I'm not positive it's to do with that new setting. It may have to do with us not specifying loggedInUser in webpay.

Comment 3

[Wraithan (Chris McDonald) [:wraithan]]

An undefined loggedInUser with an existing persona session should result in onlogin() being called which should just send the assertion to us and everything is good. But it appears it is calling onlogout() which, if loggedInUser is undefined should only happen if person thinks there is no session.

Comment 4

[Kumar McMillan [:kumar]]

It looks like there is a Persona bug around forced issuer which is causing this. As a workaround, I disabled issuer forcing. That fixes this specific bug but it should be re-enabled at some point. 

See bug 850084