Closed Bug 843433 Opened 7 years ago Closed 7 years ago

FileDescriptorUtils.cpp:39:300: warning: deleting object of polymorphic class type ‘mozilla::ipc::CloseFileRunnable’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

New build warning:
{
ipc/glue/FileDescriptorUtils.cpp: In member function ‘virtual nsrefcnt mozilla::ipc::CloseFileRunnable::Release()’:

ipc/glue/FileDescriptorUtils.cpp:39:300: warning: deleting object of polymorphic class type ‘mozilla::ipc::CloseFileRunnable’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]

}

This is in code added a few days ago, in bug 835698, and it can be fixed by an MOZ_FINAL annotation (which tells the compiler we don't have to worry about there being any subclasses, so we don't need a virtual destructor).  I'll push that with
blanket-r=ehsan, per bug 829975 comment 3.
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/cff90661f8ca
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.