843485 - [Statusbar] can't toggle wifi button from second time

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia, defect)

Description

[Leo]

1. Title : [Statusbar] can't toggle wifi button from second time
2. Precondition : Bring down the statusbar from homescreen and turn on/off wifi once.
3. Tester's Action : Try turning on/off wifi again.
4. Detailed Symptom (ENG.) : It simply does not do anything. 
5. Expected : Wifi should be turned on/off when toggled.
6.Reproducibility: Y
1)Frequency Rate : 100%

And the strangest thing is, once 'airplane mode' is turned on/off. Then the wifi button starts working from second time.

Comment 1

[Leo]

Attachment: pull request url

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 716417 [details]
pull request url

redirect review

Comment 3

[Evelyn Hung]

Comment on attachment 716417 [details]
pull request url

Sorry, I can't reproduce the problem before applying your patch.
Could you please provide your Gaia version？

Comment 4

[Leo]

The Gaia version is 04e3e923bdae0773b0133ffa4958831b7124bf7a. Somehow I can't reproduce the problem in different Gaia version. 

Anyhow, the problem was that it was changing 'self.wifi.dataset.enabled' variable when the wifi button is toggled while the self.wifi.dataset.initializing variable was still true.

Comment 5

[Leo]

Please understand that I am setting the review flag again to draw attention to this.

Just by looking at the codes, doesn't it make sense to have this fix? In case, the wifi button is pressed again before the self.wifi.dataset.enabled or self.wifi.dataset.disabled event is triggered.

Comment 6

[Evelyn Hung]

(In reply to leo.bugzilla.gaia from comment #5)
> Just by looking at the codes, doesn't it make sense to have this fix? In
> case, the wifi button is pressed again before the self.wifi.dataset.enabled
> or self.wifi.dataset.disabled event is triggered.
The `self.wifi.dataset.initializing` intends to prevent clicking the button twice or more before the `self.wifi.dataset.enabled` or `self.wifi.dataset.disabled` event is triggered.  That's why I commented on Github and said:
"The check here seems to be always false, because both the wifi toggles (in System/Settings app) are disabled at this moment, so the user can't change WIFI status now."

Comment 7

[Al Tsai [:atsai]]

Tested w/ different version.
I cannot reproduce this problem.
Marked as WFM and close it.
Please reopen it if it happens again.

  <!-- Mercurial-Information: <project name="releases/mozilla-b2g18" path="gecko" remote="hgmozillaorg" revision="d9278721eea1"/> -->
  <project name="gecko.git" path="gecko" remote="mozillaorg" revision="9306ad2157bb28da16e6e0442e7867a6cba76711"/>
  <!-- Mercurial-Information: <project name="integration/gaia-v1-train" path="gaia" remote="hgmozillaorg" revision="b02c8ad97ab8"/> -->
  <project name="gaia.git" path="gaia" remote="mozillaorg" revision="7636cc575be4a71fdd04879ccaf0109cf4f4a355"/>

Comment 8

[Evelyn Hung]

Comment on attachment 716417 [details]
pull request url

clear review request because we can't reproduce the problem.