Marionette virtualenv failing on multi-arch Debian-based distros

RESOLVED FIXED in Firefox 22

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: vicamo, Assigned: vicamo)

Tracking

unspecified
mozilla22
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox22 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Marionette client[1] still uses "1.8.2" and suffers from the same problem with bug 837631. Need at least commit 38d56d9[2] in upstream virtualenv to include the same change. Originally reported in bug 837631 comment #14 .

[1]: http://dxr.mozilla.org/mozilla-central/testing/marionette/client/marionette/venv_test.sh#l6
[2]: https://github.com/pypa/virtualenv/commit/38d56d9b83b9902c942412482b401fd72c2320bd
(Assignee)

Comment 1

6 years ago
Created attachment 716473 [details] [diff] [review]
fix

Correct, the oldest usable commit is 49f4012[1], which also upgrades distribute to 0.6.34. Try https://tbpl.mozilla.org/?tree=Try&rev=67b8f3bc4f50

[1]: https://github.com/pypa/virtualenv/commit/49f4012
Assignee: nobody → vyang
Status: NEW → ASSIGNED
Attachment #716473 - Flags: review?(gps)

Comment 2

6 years ago
Comment on attachment 716473 [details] [diff] [review]
fix

While I'm tempted to rubber stamp this, I don't feel comfortable giving this r+ because I'm not familiar with how marionette and virtualenv work together. e.g. it's possible we have the 1.8.2 tarball installed on a private server somewhere or something.

I'd feel much better if a core Marionette developer signed off on this.
Attachment #716473 - Flags: review?(gps)
Comment on attachment 716473 [details] [diff] [review]
fix

Review of attachment 716473 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  We don't use this script in automated infrastructure, so there aren't any concerns in that area.
Attachment #716473 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9df26f2a96fc
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/86cfd3b7de5f
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → fixed
status-firefox22: --- → fixed
You need to log in before you can comment on or make changes to this bug.