843533 - add support for tp5o to talos

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

seriously considering the option of a reduced set of pages for tp5, I want to create tp5o as a staging ground for this experiment, and eventually being a final solution.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add support for tp5o into talos harness (1.0)

we need to ensure we don't post these results to graph server, but datazilla is fine.

Comment 2

[Ed Morley [:emorley]]

What does the 'o' stand for? :-)

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

o = n++

Comment 4

[Ed Morley [:emorley]]

Ah :-)

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add support for tp5o into talos harness (1.1)

fixed some test definitions and verified this works great on try server (using another hack)

Comment 6

[Jeff Hammel]

(In reply to Ed Morley [:edmorley UTC+0] from comment #4)
> Ah :-)

Yeah ....the whole test suite name carrying meaning is a bit problematic in the existing system.

Comment 7

[Jeff Hammel]

Comment on attachment 717053 [details] [diff] [review]
add support for tp5o into talos harness (1.1)

+                if 'tp5o' in result:
+                    return

Why?

+class tp5o(tp):

Is it necessary to repeat all the things?  Also, the docstring should probably be updated with a description of tp5o vs just copying the tp5 docstring.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

we can't push tp5o results to graph server, otherwise we will have to deploy new sql logic and bits and there could be reported regressions although this is an experimental target at the moment.  

Good call on the pointless copying of tp5n stuff.

Comment 9

[Jeff Hammel]

Comment on attachment 717053 [details] [diff] [review]
add support for tp5o into talos harness (1.1)

+                if 'tp5o' in result:
+                    return

There should be a comment here, apropos comment 7 and comment 8 probably referencing this bug number.

+class tp5o(tp):
+    """

Please fix the docstring and please only copy what is intended to be copied, as per comment 7 and comment 8

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add support for tp5o into talos harness (1.2)

thanks for the review, this should address your concerns!

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/rev/880a267bfacc