843597 - ScratchpadManager.openScratchpad() puts the cursor at the bottom

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect, P3)

Description

[Anthony Lieuallen]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130215130331

Steps to reproduce:

I added a feature to Greasemonkey to use Scratchpad as the default script editor.
https://github.com/greasemonkey/greasemonkey/commit/4fab342c6e47af47b4ee38b011693845999ebe68#L3R1


Actual results:

I'm calling ScratchpadManager.openScratchpad() with a filename argument, which it seems to support -- but it doesn't read that file into the editor, so I'm also specifying the text argument.  Which it puts into the editor, but it then puts the cursor at the end of this text.


Expected results:

This is incongruent with the behavior that actually picking File>Open in Scratchpad displays: it puts the cursor at the top (as expected).  Pretty much every editor, when opening a new initial file at launch, or opening a file interactively, puts the cursor at the top of the file.

Either:
A) Supplying the filename argument to openScratchpad() should act exactly like picking that file after doing File>Open  (read its contents, put it in the editor, put the cursor at the top), or
B) The cursor should start at the top of the editor even when supplying initial text.

Comment 1

[Brandon Benvie [:benvie]]

Scratchpad.openScratchpad takes an optional `state` argument, which is an object that looks like:

> {
>   filename: "filename.js",
>   text: "// javascript code goes here",
>   executionContext: 1,
>   saved: true
> }

`executionContext` is 1 for content, 2 for browser
saved indicates whether there's a * next to the name (AKA editor is dirty)

If you use ScratchpadManager.openScratchpad with options like this then it should open with the cursor at the top instead of the bottom as you desire.

Comment 2

[Anthony Lieuallen]

That's exactly what I've always been doing:

https://github.com/greasemonkey/greasemonkey/blob/4fab342c6e47af47b4ee38b011693845999ebe68/modules/util/openInEditor.js#L18

Unless you're saying that the executionContext _must_ also be passed?

Comment 3

[Brandon Benvie [:benvie]]

Oh hmm. I will investigate further.

Comment 4

[Brandon Benvie [:benvie]]

You are absolutely right! I must have been seeing things.

Comment 5

[Brandon Benvie [:benvie]]

As an interim solution until we get a fix landed, you can use `scratchpad.selectRange(0, 0)` (assuming you're not already doing this as a workaround).

Comment 6

[janekptacijarabaci]

Unfortunately, it does not always work. For example:
https://github.com/greasemonkey/greasemonkey/issues/1785

Comment 7

[Anthony Lieuallen]

So what's the situation here after bug 912260 ?

Comment 8

[janekptacijarabaci]

You can set the status to "RESOLVED FIXED", see:
https://bugzilla.mozilla.org/show_bug.cgi?id=912260
https://github.com/greasemonkey/greasemonkey/commit/00989016c0c6648d8295399b8cdb58a175bb16ff

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Thanks!