843614 - B2G RIL: telephony marionette tests for bad number and call busy

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Edgar Chen [:edgar]]

In bug 839368, we added support for reporting badNumber and busy in emulator. Now we can enable test_outgoing_badNumber.js and test_outgoing_busy.js.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Part 1: Enable test_outgoing_badNumber, v1

Comment 2

[Edgar Chen [:edgar]]

Attachment: Part 2: Enable test_outgoing_busy, v1

Comment 3

[Edgar Chen [:edgar]]

try server: https://tbpl.mozilla.org/?tree=Try&rev=6b05f61f5e68

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 730005 [details] [diff] [review]
Part 1: Enable test_outgoing_badNumber, v1

Review of attachment 730005 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 730006 [details] [diff] [review]
Part 2: Enable test_outgoing_busy, v1

Review of attachment 730006 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you! B.t.w, please change r=htsai to r=hsinyi? The latter is what we are using in other patches now :)

Comment 6

[Edgar Chen [:edgar]]

Attachment: Part 1: Enable test_outgoing_badNumber, v2, r=hsinyi

Address comment #5

Comment 7

[Edgar Chen [:edgar]]

Attachment: Part 2: Enable test_outgoing_busy, v2, r=hsinyi

Address comment #5

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a0138828f01
https://hg.mozilla.org/integration/mozilla-inbound/rev/76ba219af069

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a0138828f01
https://hg.mozilla.org/mozilla-central/rev/76ba219af069